From owner-cvs-all@FreeBSD.ORG  Sat Feb  3 18:28:04 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id CF44016A401;
	Sat,  3 Feb 2007 18:28:04 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 8C8F013C4A7;
	Sat,  3 Feb 2007 18:28:04 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id l13IP6WP098858;
	Sat, 3 Feb 2007 11:25:06 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Sat, 03 Feb 2007 11:25:38 -0700 (MST)
Message-Id: <20070203.112538.-816357461.imp@bsdimp.com>
To: antoine.brodin@laposte.net
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20070203182345.c64553e6.antoine.brodin@laposte.net>
References: <200702031633.l13GXmGn001131@repoman.freebsd.org>
	<20070203182345.c64553e6.antoine.brodin@laposte.net>
X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Sat, 03 Feb 2007 11:25:06 -0700 (MST)
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/usb uipaq.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Feb 2007 18:28:04 -0000

In message: <20070203182345.c64553e6.antoine.brodin@laposte.net>
            Antoine Brodin <antoine.brodin@laposte.net> writes:
: Warner Losh <imp@FreeBSD.org> wrote:
: > imp         2007-02-03 16:33:48 UTC
: > 
: >   FreeBSD src repository
: > 
: >   Modified files:
: >     sys/dev/usb          uipaq.c 
: >   Log:
: >   Fix non-use, but not memory leak, of devinfop.  Set the device's
: >   description here.  The fix in the PR isn't necessary at all for memory
: >   leaks, but we weren't setting the device description.
: >   
: >   While I'm here, remove some of the obfuscating macros in attach.
: >   
: >   PR: 108719
: >   
: >   Revision  Changes    Path
: >   1.2       +22 -39    src/sys/dev/usb/uipaq.c
: 
: Hi Warner,
: 
: devinfop is leaked in the "goto bad;" case isn't it ?

oops, you are correct.

Warner