From owner-freebsd-current  Tue Sep 10  0:44:30 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C536937B400
	for <current@FreeBSD.ORG>; Tue, 10 Sep 2002 00:44:28 -0700 (PDT)
Received: from mail.imp.ch (mail.imp.ch [157.161.1.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9C8D543E4A
	for <current@FreeBSD.ORG>; Tue, 10 Sep 2002 00:44:27 -0700 (PDT)
	(envelope-from mb@imp.ch)
Received: from nbs.imp.ch (nbs.imp.ch [157.161.4.7])
	by mail.imp.ch (8.12.3/8.12.3) with ESMTP id g8A7iKO9091275;
	Tue, 10 Sep 2002 09:44:21 +0200 (CEST)
	(envelope-from Martin.Blapp@imp.ch)
Received: from levais.imp.ch (levais.imp.ch [157.161.4.66])
	by nbs.imp.ch (8.12.3/8.12.3) with ESMTP id g8A7iK75539245;
	Tue, 10 Sep 2002 09:44:20 +0200 (MES)
Date: Tue, 10 Sep 2002 09:49:33 +0200 (CEST)
From: Martin Blapp <mb@imp.ch>
To: Vincent Poy <vince@oahu.WURLDLINK.NET>
Cc: <current@FreeBSD.ORG>
Subject: Re: Uncommitted dc0 fixes ...
In-Reply-To: <20020909130911.U2914-100000@oahu.WURLDLINK.NET>
Message-ID: <20020910094649.C50626-100000@levais.imp.ch>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG


Hi,

> 1) dc driver uses wrong case to read MAC from eeprom.
>
> http://www.FreeBSD.org/cgi/query-pr.cgi?pr=kern/35482
>
> This one seems to break data sending/receiving as the only thing that
> works is pinging and that's only on the alias/secondary IP and not the
> primary IP network which is completely unpingable.

I expected this one to be the problem PR. I'll look at it this evening.

+       case DC_DEVICEID_EN2242:     /* and  DC_DEVICEID_EN5251B:  */
     +               if (revision < DC_REVISION_EN5251B) {
     +                       sc->dc_type = DC_TYPE_AN985;
     +               }  else {
     +                       sc->dc_type = DC_TYPE_EN5152B;
     +               }
     +               sc->dc_flags |= DC_TX_USE_TX_INTR;
     +               sc->dc_flags |= DC_TX_ADMTEK_WAR;
     +               sc->dc_pmode = DC_PMODE_MII;
     +               break;
             case DC_DEVICEID_AN985:
     -       case DC_DEVICEID_EN2242:
                     sc->dc_type = DC_TYPE_AN985;
                     sc->dc_flags |= DC_TX_USE_TX_INTR;
                     sc->dc_flags |= DC_TX_ADMTEK_WAR;

This change looks wrong to me.

Martin


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message