From owner-cvs-all@FreeBSD.ORG Sat Mar 29 06:52:09 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C2E837B401; Sat, 29 Mar 2003 06:52:09 -0800 (PST) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id C41EF43F3F; Sat, 29 Mar 2003 06:52:08 -0800 (PST) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.12.8/8.12.8) with SMTP id h2TEq3jK027149; Sat, 29 Mar 2003 09:52:03 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Sat, 29 Mar 2003 09:52:02 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?= In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/lib url.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Mar 2003 14:52:12 -0000 On Sat, 29 Mar 2003, Dag-Erling Sm=F8rgrav wrote: > Robert Watson writes: > > Log: > > Don't pass NULL in as a flags argument to libfetch's fetchGetURL() > > as this can result in a NULL pointer deference when parsing the > > flags later. This change fixes "pkg_add -r" on 5.0-CURRENT for > > me; not quite clear how the problem was introduced. >=20 > Umm, this was already fixed in libfetch more than a week ago. Interesting, because it was still segfaulting for me with a fresh -current the same day I committed the change. :-) I'm currently in the process of packing to move apartments, but I'll see if I can't get a system up using today's -current and without that change and see what happens soemtime today. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories