From nobody Fri Jun 26 18:59:59 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gn4jq2xPQz6hjYR for ; Fri, 26 Jun 2026 18:59:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gn4jq24xwz3YZC for ; Fri, 26 Jun 2026 18:59:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782500399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rZeN9ohUh3qykZMqKag2e0R0jnZYHH3ZL7EwiESugQE=; b=HW8WTc8mLBUCn34KGliAwNlVyGmCQ8zO8mPZ8wBbDhvbFhDUcIdjOVPNjcOe1QT+QWBU1P XyQZUYEQcmiSs3aFqKyJXiUOKKWnXgnK9UN1AgLKuGguvKCJs+zhX95VvZvQYUwzSY3kaV 6ecKEXAUBeQ5uF8cGNWTI8Fv3ByRAgPeIfJ1IrsuWmnMCFooj4z2pv5I8LtCzvdwZrbNbq NSzJj9WZYoISzJA7cbWqKg+xsecxWLlAy4OT8i3ExNUQspvGmO3ooYU8RAZbmCPJTqLsXF wPDyJ/VzjPFBcy1U0WqxIUnRVlyZE6kCvUxS1SrQ/egDxAQ6V7/LDSoQ6rziFg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782500399; a=rsa-sha256; cv=none; b=GdLR4hkrMpTUaTQz2drfG+u3cbU6MrbphVFPU8NSOFEtTYnIBmlKoS27rSo3n0mF3OzYBE 6Ptz9vIcNx0pPs4xmaYnalZ8J3hmFg8NkUVhNvZL2hGBoNgSmN/3NMi8a1e4qfWm5w/5MJ q7OXFJj6c2TK3PzbCg4ywl0snJqG9LhPqQCEYsXLZZZrNmI8qcScymehnRRpi83LRiPSqg pS0VvSRT3HblIusHb8UThEvELt5aTgpMtIhzvnX2EJ1bnXfYbfmpqbTJfNGSdXWKC5QmjY SPOrUeSOKtrh4G771dPAYMSHM1k6CczMMJeswT7ms1yH60QhGAUMWw+6pl03oA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782500399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rZeN9ohUh3qykZMqKag2e0R0jnZYHH3ZL7EwiESugQE=; b=mwSD4SdkinLH2sw3uTv3xB6iB5XZZLuk/3BmNghf+fVMWNgpLqfiyB+cvdpSxwIZztJK8U oSVFVgOE3tqmKDOEsl1Mn2/J2IaNdjxGprF2S0t5zHOEPPYOuvzPJTTlAjRFoMG0eU9pTx 4AYUYF2d0uFqL458sJM5b1NWc9YrEJIeWplwiDSJDBjoPWmUvO0fyGn70DoG0R2YKqhvM3 TMpdDAdSssDi+NVWN46eFX2qmeD4a/55lJ3hHe1bQjsYkRkTWSTCIKZktPJ3xtCY13zL7k yQPO08/PND5GGXN0Lf5zR+mABjdeojXn3uF6Ofyfs9Dn5xGA6mSXnJvHJAayyg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gn4jq16nGzqhZ for ; Fri, 26 Jun 2026 18:59:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 41984 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 26 Jun 2026 18:59:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Aymeric Wibo Subject: git: 0cedb626959c - main - iichid(4): Always release interrupt resource List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: obiwac X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0cedb626959c0bbab6497d1f042beddab059bdaa Auto-Submitted: auto-generated Date: Fri, 26 Jun 2026 18:59:59 +0000 Message-Id: <6a3ecc2f.41984.21320940@gitrepo.freebsd.org> The branch main has been updated by obiwac: URL: https://cgit.FreeBSD.org/src/commit/?id=0cedb626959c0bbab6497d1f042beddab059bdaa commit 0cedb626959c0bbab6497d1f042beddab059bdaa Author: Aymeric Wibo AuthorDate: 2026-06-26 18:52:25 +0000 Commit: Aymeric Wibo CommitDate: 2026-06-26 18:52:28 +0000 iichid(4): Always release interrupt resource Reviewed by: aokblast Event: Halifax Hackathon 202606 Location: Chair Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57886 --- sys/dev/iicbus/iichid.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/dev/iicbus/iichid.c b/sys/dev/iicbus/iichid.c index 430066bd8f52..d13520017e93 100644 --- a/sys/dev/iicbus/iichid.c +++ b/sys/dev/iicbus/iichid.c @@ -1163,15 +1163,15 @@ iichid_attach(device_t dev) } if (sc->irq_res == NULL || error != 0) { + device_printf(sc->dev, "Interrupt setup failed\n"); + if (sc->irq_res != NULL) + bus_release_resource(dev, SYS_RES_IRQ, sc->irq_rid, + sc->irq_res); #ifdef IICHID_SAMPLING device_printf(sc->dev, "Using sampling mode\n"); sc->sampling_rate_slow = IICHID_SAMPLING_RATE_SLOW; #else - device_printf(sc->dev, "Interrupt setup failed\n"); - if (sc->irq_res != NULL) - bus_release_resource(dev, SYS_RES_IRQ, sc->irq_rid, - sc->irq_res); iichid_detach(dev); error = ENXIO; goto done;