From owner-p4-projects@FreeBSD.ORG  Tue Dec  2 17:33:00 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0B3E416A4D0; Tue,  2 Dec 2003 17:33:00 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D97B316A4CE
	for <perforce@freebsd.org>; Tue,  2 Dec 2003 17:32:59 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 36F1943FDF
	for <perforce@freebsd.org>; Tue,  2 Dec 2003 17:32:59 -0800 (PST)
	(envelope-from peter@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id hB31WxXJ092014
	for <perforce@freebsd.org>; Tue, 2 Dec 2003 17:32:59 -0800 (PST)
	(envelope-from peter@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.9/8.12.9/Submit) id hB31WwQC092011
	for perforce@freebsd.org; Tue, 2 Dec 2003 17:32:58 -0800 (PST)
	(envelope-from peter@freebsd.org)
Date: Tue, 2 Dec 2003 17:32:58 -0800 (PST)
Message-Id: <200312030132.hB31WwQC092011@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	peter@freebsd.org using -f
From: Peter Wemm <peter@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 43335 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Dec 2003 01:33:00 -0000

http://perforce.freebsd.org/chv.cgi?CH=43335

Change 43335 by peter@peter_overcee on 2003/12/02 17:32:38

	actually, since we've already checked for zero in the loop,
	directly call bsfq() rather than "ffsl() - 1".  In theory,
	gcc -O should optimize out the mask == 0 case (already tested)
	and the "- 1 + 1", but dont depend on it.  This is why we have
	RQB_FFS() exposed like this anyway.

Affected files ...

.. //depot/projects/hammer/sys/amd64/include/runq.h#6 edit

Differences ...

==== //depot/projects/hammer/sys/amd64/include/runq.h#6 (text+ko) ====

@@ -36,7 +36,7 @@
 #define	RQB_BIT(pri)	(1 << ((pri) & (RQB_BPW - 1)))
 #define	RQB_WORD(pri)	((pri) >> RQB_L2BPW)
 
-#define	RQB_FFS(word)	(ffsl(word) - 1)
+#define	RQB_FFS(word)	(bsfq(word))
 
 /*
  * Type of run queue status word.