From owner-freebsd-ports-bugs@freebsd.org Sat Sep 7 11:52:18 2019 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 79CD6EEE0A for ; Sat, 7 Sep 2019 11:52:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46QXpp2fZpz4Sh7 for ; Sat, 7 Sep 2019 11:52:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 5B079EEE09; Sat, 7 Sep 2019 11:52:18 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5ACCEEEE08 for ; Sat, 7 Sep 2019 11:52:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46QXpp1mSHz4Sh6 for ; Sat, 7 Sep 2019 11:52:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 215E252B0 for ; Sat, 7 Sep 2019 11:52:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x87BqIHC076451 for ; Sat, 7 Sep 2019 11:52:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x87BqItC076450 for ports-bugs@FreeBSD.org; Sat, 7 Sep 2019 11:52:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 240375] [NEW PORT] www/py-isso: A commenting server similar to Disqus Date: Sat, 07 Sep 2019 11:52:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Sep 2019 11:52:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240375 --- Comment #4 from Kubilay Kocak --- (In reply to Ren=C3=A9 Th=C3=BCmmler from comment #3) My pleasure Ren=C3=A9, you're welcome & very nice work A few nits: - No need for a PORTREVISION for a new (not yet committed port) - misaka has a max version pin, one must either declare that, or patch it o= ut. misaka>=3D2.0<3.0 should work - Upstream specifies =3D=3D2.7 as the environment marker, so match that (in= stead of (PYTHON_REL < 3000) where possible. In these "=3D=3D" cases, one can use _RUN_DEPENDS helpers, like: py27_RUN_DEPENDS=3D foo \ bar - I'd use ${ETCDIR} rather than ${PREFIX}/etc in post-patch (it covers more= of the path), unless it makes the REINPLACE search/replace 'too' challenging or less readable. Likewise for post-install (use ETCDIR) - For sqlite3, does this actually need the "sqlite module in Python" ? If s= o, depend on databases/py-sqlite3 directly (we split that module out from the stdlib/language ports). If this is the case, remove sqlite:3 from USES --=20 You are receiving this mail because: You are the assignee for the bug.=