From owner-cvs-all Sun Nov 10 18:13: 1 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D177E37B401; Sun, 10 Nov 2002 18:12:59 -0800 (PST) Received: from beppo.feral.com (beppo.feral.com [192.67.166.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F74443E75; Sun, 10 Nov 2002 18:12:59 -0800 (PST) (envelope-from mjacob@feral.com) Received: from mailhost.feral.com (mjacob@mailhost.feral.com [192.67.166.1]) by beppo.feral.com (8.11.3/8.11.3) with ESMTP id gAB2CsZ63219; Sun, 10 Nov 2002 18:12:54 -0800 (PST) (envelope-from mjacob@feral.com) Date: Sun, 10 Nov 2002 18:12:54 -0800 (PST) From: Matthew Jacob X-Sender: mjacob@beppo Reply-To: mjacob@feral.com To: "Alan L. Cox" Cc: Jake Burkholder , Matt Jacob , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm uma_dbg.c In-Reply-To: <3DCEAA0E.337BF15B@imimic.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Sorry for the delay- I took the kid to see gramma... Sure- let me look at this a little closer - I'll interrupt the make release and try a different approach. Sorry for not reading the atomic stuff closer. I mean, after all, I believe that sparc *does* have atomic byte instructions. My bad for not reading the man page closeer. -matt On Sun, 10 Nov 2002, Alan L. Cox wrote: > Jake Burkholder wrote: > > > > Apparently, On Sun, Nov 10, 2002 at 08:16:44AM -0800, > > Matt Jacob said words to the effect of; > > > > > mjacob 2002/11/10 08:16:44 PST > > > > > > Modified files: > > > sys/vm uma_dbg.c > > > Log: > > > Use atomic_set_8 on the us_freelist maps as they are not otherwise > > > protected. Furthermore, in some RISC architectures with no normal > > > byte operations, the surrounding 3 bytes are also affected by the > > > read-modify-write that has to occur. > > > > > > Revision Changes Path > > > 1.9 +2 -2 src/sys/vm/uma_dbg.c > > > > sparc64 can't do atomic operations on less than 32 bits, this needs > > a lock. > > > > Matt, can you try acquiring and releasing the zone mutex in > uma_dbg_alloc() and uma_dbg_free() instead? > > Alan > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message