From owner-freebsd-bugs@freebsd.org Tue May 26 04:30:10 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DAC172DFCBD for ; Tue, 26 May 2020 04:30:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 49WLbk5Y7gz4KTR for ; Tue, 26 May 2020 04:30:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id BE80C2DFCBB; Tue, 26 May 2020 04:30:10 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BE4A92DFB73 for ; Tue, 26 May 2020 04:30:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49WLbk4bLpz4KR1 for ; Tue, 26 May 2020 04:30:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7EFA01DAFC for ; Tue, 26 May 2020 04:30:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 04Q4UAZM066777 for ; Tue, 26 May 2020 04:30:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 04Q4UAgq066761 for bugs@FreeBSD.org; Tue, 26 May 2020 04:30:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 246735] [PATCH] Do not restrict fortune(6) to only searching for files named "fortunes" by default Date: Tue, 26 May 2020 04:30:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: nipkraps@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2020 04:30:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D246735 Bug ID: 246735 Summary: [PATCH] Do not restrict fortune(6) to only searching for files named "fortunes" by default Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: nipkraps@gmail.com Created attachment 214860 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D214860&action= =3Dedit Patch to allow fortune(6) to look for all fortune files in the fortune directory Currently, fortune(6) by default looks in the fortune directory for a data = file named "fortunes", and if none are found, displays "No fortunes found". Any fortune file must be explicitly specified; ex. to display a fortune from the file "freebsd-tips" one must use the command "fortune freebsd-tips". Previously, this behaviour would be acceptable, as a "fortunes" data file u= sed to be packaged with the base system, but as of base r325828, FreeBSD does n= ot distribute such a data file. This may be unexpected to users who expect "fortune" to generate a fortune from "freebsd-tips", which is distributed w= ith the base system. This patch removes this restriction on fortune(6). The new default behaviour would be to look for any file within the default fortunes directory, regard= less of name. By default, this will result in fortune(6) yielding fortunes from freebsd-tips, with fortunes being yielded from various sources as more are installed (either locally or via ports/pkg). This behaviour may be somewhat unexpected to users who are used to the old behaviour of fortune(6), but is= not likely to cause breaking issues. Users who wish to return to the old behavi= our will be able to use the command "fortune fortunes" to replicate it. This patch fixes bug #237768 and was originally posted on that bug's thread= by me two months ago. I am terribly sorry if this isn't the correct procedure = for submitting a patch to a preexisting bug; I'm new to contributing to FreeBSD= and I'm not entirely certain if the wording found in the "Contributing to FreeB= SD" handbook suggests that a new bug report should be opened for patches which = fix bugs which already have reports filed. --=20 You are receiving this mail because: You are the assignee for the bug.=