From owner-cvs-all@FreeBSD.ORG Fri Apr 4 13:09:25 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B76C37B401; Fri, 4 Apr 2003 13:09:25 -0800 (PST) Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 58DB943FBD; Fri, 4 Apr 2003 13:09:24 -0800 (PST) (envelope-from des@ofug.org) Received: by flood.ping.uio.no (Postfix, from userid 2602) id F03B05309; Fri, 4 Apr 2003 23:09:22 +0200 (CEST) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Kris Kennaway From: des@ofug.org (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=) Date: Fri, 04 Apr 2003 23:09:22 +0200 In-Reply-To: <20030404182223.GA36706@HAL9000.homeunix.com> (David Schultz's message of "Fri, 4 Apr 2003 10:22:23 -0800") Message-ID: User-Agent: Gnus/5.090015 (Oort Gnus v0.15) Emacs/21.2 References: <200304041729.h34HTtVb027430@repoman.freebsd.org> <20030404173635.GA22147@rot13.obsecurity.org> <20030404182223.GA36706@HAL9000.homeunix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 identcpu.c support.s src/sys/i386/include md_var.h src/sys/i386/isa npx.c src/sys/ia64/ia64 support.s src/sys/powerpc/powerpc bcopy.c src/sys/sparc64/sparc64 support.S ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Apr 2003 21:09:25 -0000 David Schultz writes: > BTW, why does this change convert bcopy from a function pointer to > a function that jumps to the address of a pointer? This looks > like a net gain in lines of code and a net gain in pipeline > stalls. Is there something in particular that it makes easier? Just code hygiene. There is no such optimization for bzero or any of the other functions in support.s (copyin, copyout), and it required an i386-specific declaration in . Of course, if the consensus is that this micro-optimization is desirable, I'll back out this part of the patch, but in that case I'll turn the other functions into pointers as well rather than have a mixed bag. DES --=20 Dag-Erling Sm=F8rgrav - des@ofug.org