Date: Mon, 30 Jul 2012 14:01:45 +0800 From: David Xu <listlog2011@gmail.com> To: Bruce Evans <brde@optusnet.com.au> Cc: Garrett Cooper <yanegomi@gmail.com>, freebsd-bugs@FreeBSD.org, davidxu@FreeBSD.org Subject: Re: kern/170203: [kern] piped dd' s don' t behave sanely when dealing with a fifo Message-ID: <50162349.8070209@gmail.com> In-Reply-To: <20120729191243.D2283@besplex.bde.org> References: <201207272150.q6RLo9ew012879@freefall.freebsd.org> <501482CD.6050708@gmail.com> <CAGH67wQYCf6N0hF4Hru63snCxVoPjBmLgjyPkVBRT7q7%2BgcqbQ@mail.gmail.com> <50148F42.20105@gmail.com> <5014A64A.3010106@gmail.com> <20120729191243.D2283@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012/7/29 17:16, Bruce Evans wrote: > On Sun, 29 Jul 2012, David Xu wrote: > >>> I have just written two quick-and-dirty test cases: >>> >>> http://people.freebsd.org/~davidxu/patch/fifopipe/fifo_selectread.c >>> http://people.freebsd.org/~davidxu/patch/fifopipe/fifo_selectwrite.c >>> >>> without patch for kernel code, a child process will print out >>> "timeout". > >> I have updated patch, the patch fixed lost-notification bug for >> select(): >> http://people.freebsd.org/~davidxu/patch/fifopipe/kernel_pipe2.diff > > So it was a bug in the new pipe code. > My patch only fixes the lost of notification, it is not intent to fix the problems in /usr/src/tools/regression/poll tests, I think those are other more detailed implementation problems. > The test seemed to work under FreeBSD-~5.2 but was hard to configure. > It gave lots of abort traps. One was for the big buffer. This is too > big for -current too, and causes a mysterious abort trap with no core, > before exec. truss, gdb and bde were confused. > I am sorry that you were confused, I have updated fifo_selectread.c, it had a large buffer which is a left-over from my another local program, I have removed the buffer. > Bruce > Regards, David Xu
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50162349.8070209>