From owner-freebsd-rc@FreeBSD.ORG Wed Feb 24 01:53:42 2010 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DFCEE106564A; Wed, 24 Feb 2010 01:53:42 +0000 (UTC) (envelope-from cyrille.lefevre-lists@laposte.net) Received: from out4.laposte.net (out3.laposte.net [193.251.214.120]) by mx1.freebsd.org (Postfix) with ESMTP id 93B0E8FC29; Wed, 24 Feb 2010 01:53:42 +0000 (UTC) Received: from out3.laposte.net (lbao93aubmepnpf001-183-pip.meplus.info [10.98.50.10]) by mwinf8310.laposte.net (SMTP Server) with ESMTP id 6209E1C0017F; Wed, 24 Feb 2010 02:19:02 +0100 (CET) Received: from meplus.info (localhost [127.0.0.1]) by mwinf8302.laposte.net (SMTP Server) with ESMTP id 41109E000086; Wed, 24 Feb 2010 02:19:00 +0100 (CET) Received: from [192.168.1.133] (84.228.100-84.rev.gaoland.net [84.100.228.84]) by mwinf8302.laposte.net (SMTP Server) with ESMTP id C6B26E000083; Wed, 24 Feb 2010 02:18:59 +0100 (CET) X-ME-UUID: 20100224011859813.C6B26E000083@mwinf8302.laposte.net Message-ID: <4B847E98.5040209@laposte.net> Date: Wed, 24 Feb 2010 02:19:20 +0100 From: Cyrille Lefevre Organization: ACME User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Doug Barton References: <200912200134.nBK1YCAA048942@svn.freebsd.org> <4B2DBB51.9060002@FreeBSD.org> <4B2DD2A1.8060907@FreeBSD.org> <4B2E84CF.2060902@FreeBSD.org> In-Reply-To: <4B2E84CF.2060902@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-me-spamlevel: not-spam X-me-spamrating: 36.000000 X-me-spamcause: OK, (-100)(0000)gggruggvucftvghtrhhoucdtuddrvdeltddrgeehucetggdotefuucfrrhhofhhilhgvmecuoehnohhnvgeqnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, freebsd-rc@FreeBSD.org, Hajimu UMEMOTO Subject: Re: svn commit: r200743 - in head/usr.sbin: . service X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2010 01:53:43 -0000 Doug Barton a =E9crit : > I agree to making the change you suggested, but I would like to > quibble over the format. Isn't the attached patch equivalent, and > simpler? What is the value of setting HOME and PATH in the environment > if we're just going to use 'env -i HOME PATH' anyway? how about to replace $* by "$@" in service.sh and to quote $dir/$script=20 as well ? before : exec env -i HOME=3D/ PATH=3D/sbin:/bin:/usr/sbin:/usr/bin $dir/$script $*= after : exec env -i HOME=3D/ PATH=3D/sbin:/bin:/usr/sbin:/usr/bin "$dir/$script" = "$@" Regards, Cyrille Lefevre --=20 mailto:Cyrille.Lefevre-lists@laposte.net