From owner-freebsd-ports Wed Nov 26 11:40:03 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id LAA13158 for ports-outgoing; Wed, 26 Nov 1997 11:40:03 -0800 (PST) (envelope-from owner-freebsd-ports) Received: (from gnats@localhost) by hub.freebsd.org (8.8.7/8.8.7) id LAA13137; Wed, 26 Nov 1997 11:40:02 -0800 (PST) (envelope-from gnats) Date: Wed, 26 Nov 1997 11:40:02 -0800 (PST) Message-Id: <199711261940.LAA13137@hub.freebsd.org> To: freebsd-ports Cc: From: Jeff Bartig Subject: Re: ports/5095: enscript port ignores Makefile media size flags Reply-To: Jeff Bartig Sender: owner-freebsd-ports@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk The following reply was made to PR ports/5095; it has been noted by GNATS. From: Jeff Bartig To: FreeBSD-gnats-submit@freebsd.org, kline@thought.org Cc: Subject: Re: ports/5095: enscript port ignores Makefile media size flags Date: Wed, 26 Nov 1997 13:40:04 -0600 (CST) --ELM880573204-21592-0_ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit I messed up when I sent in my suggested patch to fix this problem. It was a little too simple. The --with-media= option on configure will only work if the value is capitalized (Letter or A4). It doesn't complain if letter or a4 are used, but the resulting enscript.cfg file will have the wrong values. Here is the correct diff's. I have tried making, installing, and running enscript with both the A4 and Letter options. Sorry about the mistake. Jeff -- Jeff Bartig | University of Wisconsin - Madison 1210 W Dayton, Rm 3219 | Division of Information Technology Work Phone: (608) 262-8336 | Network Engineering Technology E-Mail: jeffb@doit.wisc.edu | --ELM880573204-21592-0_ Content-Type: text/plain; charset=ISO-8859-1 Content-Disposition: attachment; filename=Makefile.diff Content-Description: Makefile.diff Content-Transfer-Encoding: 7bit *** Makefile.old Wed Nov 19 12:50:03 1997 --- Makefile Thu Nov 20 16:25:34 1997 *************** *** 15,21 **** GNU_CONFIGURE= yes USE_GMAKE= yes ! CONFIGURE_ARGS= --disable-nls MAKE_FLAGS= WIDTH=${WIDTH} HEIGHT=${HEIGHT} A4_PAPERSIZE=${A4_PAPERSIZE} -f MAN1= enscript.1 sliceprint.1 states.1 --- 15,21 ---- GNU_CONFIGURE= yes USE_GMAKE= yes ! CONFIGURE_ARGS= --disable-nls --with-media=${PAPERSIZE} MAKE_FLAGS= WIDTH=${WIDTH} HEIGHT=${HEIGHT} A4_PAPERSIZE=${A4_PAPERSIZE} -f MAN1= enscript.1 sliceprint.1 states.1 *************** *** 25,42 **** #LDFLAGS+=-static .if !defined(PAPERSIZE) ! PAPERSIZE=a4 # set default WIDTH=8.27 HEIGHT=11.64 A4_PAPERSIZE=1 PAPERSIZE_UNSPECIFIED= yes .elif ${PAPERSIZE} == A4 || ${PAPERSIZE} == a4 ! PAPERSIZE=a4 WIDTH=8.27 HEIGHT=11.64 A4_PAPERSIZE=1 .elif ${PAPERSIZE} == letter || ${PAPERSIZE} == LETTER || ${PAPERSIZE} == Letter ! PAPERSIZE=letter WIDTH=8.5 HEIGHT=11.0 A4_PAPERSIZE=0 --- 25,42 ---- #LDFLAGS+=-static .if !defined(PAPERSIZE) ! PAPERSIZE=A4 # set default WIDTH=8.27 HEIGHT=11.64 A4_PAPERSIZE=1 PAPERSIZE_UNSPECIFIED= yes .elif ${PAPERSIZE} == A4 || ${PAPERSIZE} == a4 ! PAPERSIZE=A4 WIDTH=8.27 HEIGHT=11.64 A4_PAPERSIZE=1 .elif ${PAPERSIZE} == letter || ${PAPERSIZE} == LETTER || ${PAPERSIZE} == Letter ! PAPERSIZE=Letter WIDTH=8.5 HEIGHT=11.0 A4_PAPERSIZE=0 --ELM880573204-21592-0_--