Date: Tue, 11 Jul 2023 12:47:27 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 271954] [NEW PORT] x11-wm/emwm Enhanced Motif Window Manager Message-ID: <bug-271954-7788-0qxa8DQnUw@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-271954-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-271954-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271954 Stephan Lichtenauer <stephan@lichtenauer.co.za> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #243082|0 |1 is obsolete| | Attachment #243339| |maintainer-approval+ Flags| | --- Comment #5 from Stephan Lichtenauer <stephan@lichtenauer.co.za> --- Created attachment 243339 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D243339&action= =3Dedit New emwm port Thanks a lot for your very quick feedback, Robert. > Thank you for the update. This is a lot better. Portlint still shows a = few warnings though, perhaps you can check them? It seems like it is confu= sed because you swapped the MAINTAINER and LICENSE blocks. Ran it through portlint, should be fine now. > A test build reveals that you use the PORTDOCS variable despite no DOCS v= ariable being defined. Either put the README file into pkg-plist or add a = DOCS option (probably overkill). I removed the README (PORTDOCS) as it does not contain any useful informati= on beyond build dependencies anyway. > A build test succeeds but there is this warning: > WmError.c:121:24: warning: incompatible function pointer types passing 'v= oid (char *)' to parameter of type 'void (*)(String) __attribute__((noretur= n))' (aka 'void (*)(char *) __attribute__((noreturn))') [-Wincompatible-fun= ction-pointer-types]=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 > [...] > This warning is known to have become an error in LLVM16, which will be th= e default on FreeBSD 14.=20=20 Added a patch for this error. > I noticed that the MAINTAINER email address in the port is different from= the one you use on bugzilla. This may lead to problems as people will not= immediately see that you are the maintainer. Also, we have hooks to auto-= notify the maintainer when a bug is files against one of his/her ports. Ar= e you okay with me changing the MAINTAINER address in the patch to the same= you use on bugzilla? Fixed this as well. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-271954-7788-0qxa8DQnUw>