From owner-svn-ports-all@FreeBSD.ORG  Wed Aug 13 16:06:16 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id CADEBB04;
 Wed, 13 Aug 2014 16:06:16 +0000 (UTC)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9F7592A64;
 Wed, 13 Aug 2014 16:06:16 +0000 (UTC)
Received: from [192.168.192.25] (dhcp-108-170-169-12.cable.user.start.ca
 [108.170.169.12])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by apnoea.adamw.org (Postfix) with ESMTPSA id E4EC515ED20;
 Wed, 13 Aug 2014 12:06:12 -0400 (EDT)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: svn commit: r364753 - in head/www/gatling: . files
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <0F2D6AC291CD1849F46DBCD4@ogg.in.absolight.net>
Date: Wed, 13 Aug 2014 12:06:11 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <079E1977-AEC8-4B15-856E-DFC3A1D16FD6@adamw.org>
References: <201408130315.s7D3FWYs042556@svn.freebsd.org>
 <1407942463.639247.546514528.132749.2@c-st.net>
 <20140813152833.GA90841@FreeBSD.org>
 <0F2D6AC291CD1849F46DBCD4@ogg.in.absolight.net>
To: Mathieu Arnold <mat@FreeBSD.org>
X-Mailer: Apple Mail (2.1878.6)
Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org,
 Carlo Strub <cs@FreeBSD.org>, vanilla@FreeBSD.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Aug 2014 16:06:16 -0000

On 13 Aug, 2014, at 11:41, Mathieu Arnold <mat@FreeBSD.org> wrote:

>=20
>=20
> +--On 13 ao=FBt 2014 15:28:33 +0000 Alexey Dokuchaev =
<danfe@FreeBSD.org>
> wrote:
> | On Wed, Aug 13, 2014 at 05:07:43PM +0200, Carlo Strub wrote:
> |> 13/08/2014 05:16 - Vanilla I. Shu wrote:
> |> > New Revision: 364753
> |> > URL: http://svnweb.freebsd.org/changeset/ports/364753
> |> > QAT: https://qat.redports.org/buildarchive/r364753/
> |> >=20
> |> > [...]
> |> > -OPTIONS_DEFINE=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS
> |> > -OPTIONS_DEFAULT=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS
> |> > +OPTIONS_DEFINE=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS DOCS
> |> > EXAMPLES DEBUG +OPTIONS_SUB=3D yes
> |> > +OPTIONS_DEFAULT=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS DOCS
> |> > EXAMPLES
> |>=20
> |> These large changes, especially the new options, merit a =
PORTREVISION
> |> bump, no?
> |=20
> | No, why?  Default options already include DOCS and EXAMPLES; the =
above
> | change in OPTIONS_DEFAULT is actually useless.
>=20
> OPTIONS_DEFAULT, yes, but they were not present in OPTIONS_DEFINE, =
thus
> were not there.  There should have been a PORTREVISION bump with this
> change.
>=20
> --=20
> Mathieu Arnold
>=20

And while you=92re bumping PORTREVISION, can you please unmute the =
installation commands? And put parentheses around your compound commands =
(cd ${WRKSRC} && ${INSTALL...)

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org