From owner-dev-commits-src-main@freebsd.org Mon Jan 25 23:07:08 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9FD6A4F5D40; Mon, 25 Jan 2021 23:07:08 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DPlqw3w84z3pGD; Mon, 25 Jan 2021 23:07:08 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm1-x329.google.com with SMTP id c127so1035349wmf.5; Mon, 25 Jan 2021 15:07:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/Mi1WrFisRSQKDSCQfxMEBw7yY6sfLxsEi/qT3Nh/Yc=; b=Atf8zVxbd++BBPuU1QYqrc1TZMwny2nH3OJ+/C7n6IMHzrdIFrLZGIHJuiMnb/9LFF abuV30tqfpQkXtsLLqsSyYD/GX37eVGphPHR8qkLEl0FESlzC/RnMyHZVEenDC2uIiDY T/kLZvhfDFmTZHetk2BWihwe8dHfc9ek+hx5zMTd9Y9zuOIVhO3wFhxovf+nWpfJxA7s kx4v9NErduELSAqxpaPGetaAIXNPoYUtr3oIRY7kUq6U75HWdae66sxPoOunDPip/X8p 4+qEdjhcrq2F6g2NPDUBpebFeAHxSFJEHyl+JxtPS9zIwHmTbEtG5AJNno6mQ5WnfThN mlHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/Mi1WrFisRSQKDSCQfxMEBw7yY6sfLxsEi/qT3Nh/Yc=; b=h620v8V7kz64xY5LthBJFxYDSlkUOHOylwzllopr6WN9+dtN0kev6DS7AUH9aFHypr Oy6N9w3EvkMQ8rCk/XvfOl3BtraQdl3bz7SNf1SCmzKAC5V4z8cTbhbT0m+WfWHkm5c/ OPNaFHtmEsjw/DjJP81tO/66BJhhchHhkxyXQ94pKIjgw4ZBcpVMGp6B9dr66qh1hS3w TU91elXRrUhTvilWMWOwZ7qPUJN1OD6Gy8MHVSJLhR+avvS4eSJrcczlwoMVsAdgvaiq Z3X17v6XfVIcNL5Qj/M6G4L3ppnReiZQopZ85+xUX5IAyBesqf+vRftuqEE4NtfxTF3z HR9Q== X-Gm-Message-State: AOAM531FKxb5XhVQmKG+ZiC33/w9kWaZW6ixAcIBJZQFaFFwkQy85PM1 ZJu82aX03LW6btQ+PqMKvQVIbu94ufiMB08zfa8wwLDLu64= X-Google-Smtp-Source: ABdhPJxrTLGmdHkHRXzndarO990SFaFmuGb89VY2qaH/7kYe6y8ZiAQJKkXQSHdVt8KaPiqE0Q4VZ4xQBn/chwZF9d4= X-Received: by 2002:a1c:bbc6:: with SMTP id l189mr2072422wmf.187.1611616026269; Mon, 25 Jan 2021 15:07:06 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a5d:464c:0:0:0:0:0 with HTTP; Mon, 25 Jan 2021 15:07:05 -0800 (PST) In-Reply-To: References: <202101252242.10PMgZfO026271@gitrepo.freebsd.org> From: Mateusz Guzik Date: Tue, 26 Jan 2021 00:07:05 +0100 Message-ID: Subject: Re: git: cc96f92a570e - main - atomic: make atomic_store_ptr type-aware To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4DPlqw3w84z3pGD X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jan 2021 23:07:08 -0000 On 1/25/21, Jessica Clarke wrote: > On 25 Jan 2021, at 22:42, Mateusz Guzik wrote: >> index a3548977b940..4c29d132c369 100644 >> --- a/sys/sys/atomic_common.h >> +++ b/sys/sys/atomic_common.h >> @@ -58,7 +58,7 @@ >> #define atomic_store_long(p, v) \ >> (*(volatile u_long *)(p) = (u_long)(v)) >> #define atomic_store_ptr(p, v) \ >> - (*(volatile uintptr_t *)(p) = (uintptr_t)(v)) >> + (*(volatile __typeof(*p) *)(p) = (v)) > > This is in fact general enough to be any of the atomic_store_*, and > won't give any errors if you use it for a uint16_t (where it will store > a uint16_t). > Unclear if you are suggesting validating that the passed thing is a pointer or replacing the rest. The former is useful, the latter is significantly more work. -- Mateusz Guzik