From owner-svn-src-head@freebsd.org Mon Jun 25 15:43:55 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 666B6101403E; Mon, 25 Jun 2018 15:43:55 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B09DF82252; Mon, 25 Jun 2018 15:43:54 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w5PFhpNR099164; Mon, 25 Jun 2018 08:43:51 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w5PFhp8g099163; Mon, 25 Jun 2018 08:43:51 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201806251543.w5PFhp8g099163@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r335629 - in head: share/man/man4 sys/dev/vt/hw/vga In-Reply-To: <201806250939.w5P9dGMA067104@repo.freebsd.org> To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Date: Mon, 25 Jun 2018 08:43:51 -0700 (PDT) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 15:43:55 -0000 > Author: royger > Date: Mon Jun 25 09:39:16 2018 > New Revision: 335629 > URL: https://svnweb.freebsd.org/changeset/base/335629 > > Log: > vt: add option to ignore NO_VGA flag in ACPI > > To workaround buggy firmware that sets this flag when there's actually > a VGA present. > > Reported and tested by: Yasuhiro KIMURA > Sponsored by: Citrix Systems R&D > Reviewed by: kib > Differential revision: https://reviews.freebsd.org/D16003 It is generally best to avoid double negatives, couldnt this of been better named? hw.vga.acp_force_vga > > Modified: > head/share/man/man4/vt.4 > head/sys/dev/vt/hw/vga/vt_vga.c > > Modified: head/share/man/man4/vt.4 > ============================================================================== > --- head/share/man/man4/vt.4 Mon Jun 25 09:19:50 2018 (r335628) > +++ head/share/man/man4/vt.4 Mon Jun 25 09:39:16 2018 (r335629) > @@ -44,6 +44,7 @@ > In > .Xr loader.conf 5 : > .Cd hw.vga.textmode=1 > +.Cd hw.vga.acpi_ignore_no_vga=1 > .Cd kern.vty=vt > .Cd kern.vt.color..rgb="" > .Cd kern.vt.fb.default_mode="x" > @@ -196,6 +197,10 @@ prompt or in > Set to 1 to use virtual terminals in text mode instead of graphics mode. > Features that require graphics mode, like loadable fonts, will be > disabled. > +.It Va hw.vga.acpi_ignore_no_vga > +Set to 1 to force the usage of the VGA driver regardless of whether > +ACPI IAPC_BOOT_ARCH signals no VGA support. > +Can be used to workaround firmware bugs in the ACPI tables. > .It Va kern.vty > Set this value to > .Ql vt > > Modified: head/sys/dev/vt/hw/vga/vt_vga.c > ============================================================================== > --- head/sys/dev/vt/hw/vga/vt_vga.c Mon Jun 25 09:19:50 2018 (r335628) > +++ head/sys/dev/vt/hw/vga/vt_vga.c Mon Jun 25 09:39:16 2018 (r335629) > @@ -1217,6 +1217,12 @@ vga_acpi_disabled(void) > ACPI_TABLE_FADT *fadt; > vm_paddr_t physaddr; > uint16_t flags; > + int ignore; > + > + TUNABLE_INT_FETCH("hw.vga.acpi_ignore_no_vga", &ignore); > + > + if (ignore) > + return (false); > > physaddr = acpi_find_table(ACPI_SIG_FADT); > if (physaddr == 0) > > -- Rod Grimes rgrimes@freebsd.org