From owner-freebsd-ports-bugs@FreeBSD.ORG Sat May 22 13:40:04 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 887BC106564A for ; Sat, 22 May 2010 13:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (unknown [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5CA228FC15 for ; Sat, 22 May 2010 13:40:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o4MDe4le009937 for ; Sat, 22 May 2010 13:40:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o4MDe4sL009936; Sat, 22 May 2010 13:40:04 GMT (envelope-from gnats) Resent-Date: Sat, 22 May 2010 13:40:04 GMT Resent-Message-Id: <201005221340.o4MDe4sL009936@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Yuri Pankov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5254C106568C for ; Sat, 22 May 2010 13:38:28 +0000 (UTC) (envelope-from yuri.pankov@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.159]) by mx1.freebsd.org (Postfix) with ESMTP id CF0DA8FC2A for ; Sat, 22 May 2010 13:38:27 +0000 (UTC) Received: by fg-out-1718.google.com with SMTP id 22so584272fge.13 for ; Sat, 22 May 2010 06:38:26 -0700 (PDT) Received: by 10.87.69.29 with SMTP id w29mr5428362fgk.35.1274535506676; Sat, 22 May 2010 06:38:26 -0700 (PDT) Received: from darklight.org.ru ([213.132.76.142]) by mx.google.com with ESMTPS id 4sm6084545fgg.2.2010.05.22.06.38.25 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 22 May 2010 06:38:26 -0700 (PDT) Received: from darklight.org.ru (yuri@darklight.org.ru [127.0.0.1]) by darklight.org.ru (8.14.4/8.14.4) with ESMTP id o4MDcN2Q081950 for ; Sat, 22 May 2010 17:38:24 +0400 (MSD) (envelope-from yuri.pankov@gmail.com) Received: (from yuri@localhost) by darklight.org.ru (8.14.4/8.14.4/Submit) id o4MDcN2X081948; Sat, 22 May 2010 17:38:23 +0400 (MSD) (envelope-from yuri.pankov@gmail.com) Message-Id: <201005221338.o4MDcN2X081948@darklight.org.ru> Date: Sat, 22 May 2010 17:38:23 +0400 (MSD) From: Yuri Pankov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/146829: [PATCH]: bsd.port.mk: change "missing" target to run pkg_info only once X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Yuri Pankov List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 May 2010 13:40:04 -0000 >Number: 146829 >Category: ports >Synopsis: [PATCH]: bsd.port.mk: change "missing" target to run pkg_info only once >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat May 22 13:40:03 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Yuri Pankov >Release: FreeBSD 9.0-CURRENT amd64 >Organization: >Environment: System: FreeBSD darklight.org.ru 9.0-CURRENT FreeBSD 9.0-CURRENT #2 r208414M: Sat May 22 13:53:45 MSD 2010 >Description: Change "missing" target to run pkg_info only once and cache the result. Running `pkg_info -O ` for every dependency can be very time and I/O consuming when we have a large number of installed ports. >How-To-Repeat: >Fix: --- bpm.diff begins here --- Index: ports/Mk/bsd.port.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v retrieving revision 1.638 diff -u -r1.638 bsd.port.mk --- ports/Mk/bsd.port.mk 12 May 2010 19:57:57 -0000 1.638 +++ ports/Mk/bsd.port.mk 22 May 2010 13:16:32 -0000 @@ -5524,11 +5524,11 @@ # Show missing dependiencies missing: - @for dir in $$(${ALL-DEPENDS-LIST}); do \ - THISORIGIN=$${dir##${PORTSDIR}/}; \ - installed=$$(${PKG_INFO} -qO $${THISORIGIN}); \ - if [ -z "$$installed" ]; then \ - ${ECHO_CMD} $$THISORIGIN; \ + @_origins=$$(${PKG_INFO} -aoq); \ + for dir in $$(${ALL-DEPENDS-LIST}); do \ + _origin=$${dir##${PORTSDIR}/}; \ + if ! $$(${ECHO_CMD} $${_origins} | ${GREP} -q $${_origin}); then \ + ${ECHO_CMD} $${_origin}; \ fi; \ done --- bpm.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: