Date: Fri, 19 Jan 2018 10:40:49 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: John Baldwin <jhb@freebsd.org> Cc: Conrad Meyer <cem@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328159 - head/sys/modules Message-ID: <201801191840.w0JIenJ3073386@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <2915608.v56yfz43Ej@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Friday, January 19, 2018 04:34:06 AM Conrad Meyer wrote: > > Author: cem > > Date: Fri Jan 19 04:34:06 2018 > > New Revision: 328159 > > URL: https://svnweb.freebsd.org/changeset/base/328159 > > > > Log: > > Unbreak i386 build > > > > The logical result of a right shift >= the width of a type is zero, but our > > compiler decides this is a warning (and thus, error). Just remove ccp(4) > > from i386. > > You would think that. The shift instructions on x86 effectively ignore the > upper bits of the count, so a 33-bit shift on i386 ends up being a 1-bit shift, > etc. IIRC. I believe that is Rotate, not shift. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801191840.w0JIenJ3073386>