From nobody Fri Feb 21 02:56:37 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YzZXQ39GWz5nrHL; Fri, 21 Feb 2025 02:56:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YzZXQ116Jz3dNr; Fri, 21 Feb 2025 02:56:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740106598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+WFdbHoS/8Wp1vn99CQ3tU3PXPqMY9h1WX+s3rDbpPE=; b=SFhR58ou5MCQzEDDtPme5PuWmSama05srSVisrUY4uDhQr6xYdEUMPuSbIDRIAkDEKYImG 3MNJs36O3wyaUvFArFsw7juhAeD0MtRNy/sXL0Dor7CY79ZdAHNrjIr9PsbfGo/pIKATcM /UoYKePftLWUiAN2cZhwYHh+CvxF1aUfkSugh+JB32QypqIdRTSNw9MUL8mX2mOlqkDc6Z Hdj2iekDFbb1KKWcB8xfYuDM+RDAI9ZSCXedpsrQqKP7by7X3Iv8JmO0J3wDEyq2qOMPk1 yItTAzKj6GaM4BSIq88Ma5PQ6/KhVm8UMhJ4rhB7znDMjDHGb83peImZbHPrBA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740106598; a=rsa-sha256; cv=none; b=pBaSwpTIqPW+JjVcURp0c3CpI40WwLi4xAEOIARz8X1Y80Ij0xmqh6kiCdnkftyLyi2Bjc tswvQsGIFQFrVE5WZU1b/Zxn1kv1X1Q1duudq8WDXEx0O+UplcWthR+Qg5wl068ejWSBT3 iChT5hnCUbKE4C7VO2ULKJPmAFUXXXExtbBu3lIqV3EDN/JXz+mh5NioUOYVtaST7hhQhl byMEV9vtf/v4ecfkbl1Y/LuVe1emOf73XW9qwsKxic5gUVmWGHe5yXUxi+W9QLJ01NtJ5L ymSDberOF50+ihpixbtIekDsALOqNlE+EHGGiQPo9wc5FAr4XUS3MyT1ww576Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740106598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+WFdbHoS/8Wp1vn99CQ3tU3PXPqMY9h1WX+s3rDbpPE=; b=XPldNEgpQ7F85AmsXVyZxtIcH6sfd7O8ZTNl+WgJmYKoHkIxLBVohBMgO9UbsgwuKb1O31 OYHyaMPQ47m7HmSfQ/+tHq2kYcW2KXtSSjSmJ96fRoWT18hdLNsiisN/qGkwHM6e8Weq0S VCN1ZCepJdcmIhvejQentbBBeLGIZqAf1QcGvzvW/HvdoDidfmE0uo7IQeyhvMfODvKgFl n/wlWJhVLX9JMm3xrvXikWID9dwoEpzxm49JrKZCRruQrOk1VPN6pSkRck900Zyrq4mIXn Nj5rrPeSH5OcaQOgYWxjIh7Uy/WCYjMGzm+bNkFhSeGQiEWd66vOwjTAToDyMg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YzZXQ0PCtz1J2x; Fri, 21 Feb 2025 02:56:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51L2ubtK079921; Fri, 21 Feb 2025 02:56:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51L2ubaX079918; Fri, 21 Feb 2025 02:56:37 GMT (envelope-from git) Date: Fri, 21 Feb 2025 02:56:37 GMT Message-Id: <202502210256.51L2ubaX079918@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Gordon Tetlow Subject: git: 8d0540600b1e - releng/14.1 - ssh: Don't reply to PING in preauth phase or during KEX List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gordon X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.1 X-Git-Reftype: branch X-Git-Commit: 8d0540600b1ea1a58d14dfe01b8196070900ebe2 Auto-Submitted: auto-generated The branch releng/14.1 has been updated by gordon: URL: https://cgit.FreeBSD.org/src/commit/?id=8d0540600b1ea1a58d14dfe01b8196070900ebe2 commit 8d0540600b1ea1a58d14dfe01b8196070900ebe2 Author: Ed Maste AuthorDate: 2025-02-19 03:00:45 +0000 Commit: Gordon Tetlow CommitDate: 2025-02-21 02:39:07 +0000 ssh: Don't reply to PING in preauth phase or during KEX Obtained from: OpenSSH 5e07dee272c3 Security: CVE-2025-26466 Security: FreeBSD-SA-25:05.openssh Approved by: so Sponsored by: The FreeBSD Foundation (cherry picked from commit 8a16d0831e70530b2fbd682e748bd051de35f192) (cherry picked from commit 34798cb576bbd2064ab8da372112482bf8e2a7e6) --- crypto/openssh/packet.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/crypto/openssh/packet.c b/crypto/openssh/packet.c index 2d1401e7c9f5..d8fbfa28b800 100644 --- a/crypto/openssh/packet.c +++ b/crypto/openssh/packet.c @@ -1,4 +1,4 @@ -/* $OpenBSD: packet.c,v 1.313 2023/12/18 14:45:17 djm Exp $ */ +/* $OpenBSD: packet.c,v 1.318 2025/02/18 08:02:12 djm Exp $ */ /* * Author: Tatu Ylonen * Copyright (c) 1995 Tatu Ylonen , Espoo, Finland @@ -1774,6 +1774,14 @@ ssh_packet_read_poll_seqnr(struct ssh *ssh, u_char *typep, u_int32_t *seqnr_p) if ((r = sshpkt_get_string_direct(ssh, &d, &len)) != 0) return r; DBG(debug("Received SSH2_MSG_PING len %zu", len)); + if (!ssh->state->after_authentication) { + DBG(debug("Won't reply to PING in preauth")); + break; + } + if (ssh_packet_is_rekeying(ssh)) { + DBG(debug("Won't reply to PING during KEX")); + break; + } if ((r = sshpkt_start(ssh, SSH2_MSG_PONG)) != 0 || (r = sshpkt_put_string(ssh, d, len)) != 0 || (r = sshpkt_send(ssh)) != 0)