From owner-freebsd-hackers@FreeBSD.ORG Sat Jan 12 04:38:14 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id EB1E1525 for ; Sat, 12 Jan 2013 04:38:14 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by mx1.freebsd.org (Postfix) with ESMTP id 611EB2FB for ; Sat, 12 Jan 2013 04:38:14 +0000 (UTC) Received: by mail-wg0-f44.google.com with SMTP id dr12so1118936wgb.11 for ; Fri, 11 Jan 2013 20:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=hxPsLJa6nWs24VYSgHsNcTPwW3xftNIgqsCqz7TAbh4=; b=AG9FvHbymIfsnoyeBqPuZ+qcfLH0NJJXZJ9Dg7omYgGS4qrh7KskrlgCkt6f7ioE9o rG5XfvqlH7V/X6dSu8oS/GjkE+LKThYmqfxw485DEf/uXig6hdnlIQrjJGwCYGNhewNR a6/Q0wnu+CoUmz44PjnCzUiKMQ7dAMW+jpXvl1eBFzqDi8CVW+fM07ebJHkltGxWn3XP hroLNnfVgxt/upEjy1PslOQ3Ao0EXWzDZSEihfSUrkD+zsEoun+GZEczlNT1/A5mTF6Y He80M8NTCBBlOkb80Mb4o0mcPJ4KgZ2EWTfmDzWzywlIT8Fz9272UdxO0CdHWvGJbRFh em9Q== MIME-Version: 1.0 Received: by 10.194.179.34 with SMTP id dd2mr124700208wjc.1.1357965487150; Fri, 11 Jan 2013 20:38:07 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.217.57.9 with HTTP; Fri, 11 Jan 2013 20:38:07 -0800 (PST) In-Reply-To: <1357902944481-5776597.post@n5.nabble.com> References: <1357902944481-5776597.post@n5.nabble.com> Date: Fri, 11 Jan 2013 20:38:07 -0800 X-Google-Sender-Auth: AbhGs1HSCFrfP4pBLZQ-bnZh_RA Message-ID: Subject: Re: dirty hack asmc for Macbook 3,1 From: Adrian Chadd To: zeissoctopus Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jan 2013 04:38:15 -0000 Please file a PR? :) Thanks! ADrian On 11 January 2013 03:15, zeissoctopus wrote: > Dear All, > > My dirty hack just works but not perfect. > > --- /usr/src/sys/dev/asmc/asmcvar.h.original 2013-01-11 > 09:36:53.000000000 +0000 > +++ /usr/src/sys/dev/asmc/asmcvar.h 2013-01-11 10:21:02.000000000 +0000 > @@ -141,10 +141,22 @@ > #define ASMC_MB_TEMPDESCS { "Enclosure Bottomside", \ > "Northbridge Point 1", \ > "Northbridge Point 2", "Heatsink 1", \ > "Heatsink 2", "Memory Bank A", } > > +#define ASMC_MB31_TEMPS { "TB0T", "TN0P", "Th0H", "Th1H", \ > + "TM0P", NULL } > + > +#define ASMC_MB31_TEMPNAMES { "enclosure", "northbridge1", \ > + "heatsink1", "heatsink2", \ > + "memory", } > + > +#define ASMC_MB31_TEMPDESCS { "Enclosure Bottomside", \ > + "Northbridge Point 1", \ > + "Heatsink 1", "Heatsink2", \ > + "Memory Bank A", } > + > #define ASMC_MBP_TEMPS { "TB0T", "Th0H", "Th1H", "Tm0P", \ > "TG0H", "TG0P", "TG0T", NULL } > > #define ASMC_MBP_TEMPNAMES { "enclosure", "heatsink1", \ > "heatsink2", "memory", "graphics", \ > > > --- /usr/src/sys/dev/asmc/asmc.c.original 2013-01-11 > 05:26:22.000000000 +0000 > +++ /usr/src/sys/dev/asmc/asmc.c 2013-01-11 09:51:01.000000000 +0000 > @@ -153,10 +153,16 @@ > "MacBook2,1", "Apple SMC MacBook Core 2 Duo", > ASMC_SMS_FUNCS, ASMC_FAN_FUNCS, NULL, NULL, NULL, > ASMC_MB_TEMPS, ASMC_MB_TEMPNAMES, ASMC_MB_TEMPDESCS > }, > > + { > + "MacBook3,1", "Apple SMC MacBook Core 2 Duo", > + ASMC_SMS_FUNCS, ASMC_FAN_FUNCS, NULL, NULL, NULL, > + ASMC_MB31_TEMPS, ASMC_MB31_TEMPNAMES, ASMC_MB31_TEMPDESCS > + }, > + > { > "MacBookPro1,1", "Apple SMC MacBook Pro Core Duo (15-inch)", > ASMC_SMS_FUNCS, ASMC_FAN_FUNCS, ASMC_LIGHT_FUNCS, > ASMC_MBP_TEMPS, ASMC_MBP_TEMPNAMES, ASMC_MBP_TEMPDESCS > }, > > The output of this new asmc on Macbook 3,1 : > > dev.asmc.0.%desc: Apple SMC MacBook Core 2 Duo > dev.asmc.0.%driver: asmc > dev.asmc.0.%location: handle=\_SB_.PCI0.LPCB.SMC_ > dev.asmc.0.%pnpinfo: _HID=APP0001 _UID=0 > dev.asmc.0.%parent: acpi0 > dev.asmc.0.fan.0.speed: 4535 > dev.asmc.0.fan.0.safespeed: 0 > dev.asmc.0.fan.0.minspeed: 1800 > dev.asmc.0.fan.0.maxspeed: 6200 > dev.asmc.0.fan.0.targetspeed: 4525 > dev.asmc.0.temp.enclosure: 28 > dev.asmc.0.temp.northbridge1: 52 > dev.asmc.0.temp.heatsink1: 57 > dev.asmc.0.temp.heatsink2: 55 > dev.asmc.0.temp.memory: 51 > dev.asmc.0.sms.x: -20 > dev.asmc.0.sms.y: 45 > dev.asmc.0.sms.z: 264 > > Regards, > zeissoctopus > > > > -- > View this message in context: http://freebsd.1045724.n5.nabble.com/dirty-hack-asmc-for-Macbook-3-1-tp5776597.html > Sent from the freebsd-hackers mailing list archive at Nabble.com. > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"