From owner-svn-src-all@freebsd.org Thu Nov 22 04:02:29 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED94B1134C70; Thu, 22 Nov 2018 04:02:28 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7FE648857D; Thu, 22 Nov 2018 04:02:28 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 21442872C; Thu, 22 Nov 2018 04:02:28 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf1-f44.google.com with SMTP id e26so5544481lfc.2; Wed, 21 Nov 2018 20:02:28 -0800 (PST) X-Gm-Message-State: AGRZ1gJ5BgXF109OW0jZsPHG+B0L+C9bIpY1dE+ScC26EjZo3kgnPq8G JPnoGyAzlEaHV1o6pjbAHzfBrjFaNsFNZ/T3LUc= X-Google-Smtp-Source: AJdET5esQC6QcdLFhOd9i1faSblp+m0uVt5ZIPvOT7zFiy2+dN6ARkdHF0Bry1PYEDIW+0d/8OboJjUafY9ugfTCRDg= X-Received: by 2002:a19:cd50:: with SMTP id d77mr5235522lfg.125.1542859346691; Wed, 21 Nov 2018 20:02:26 -0800 (PST) MIME-Version: 1.0 References: <201810210208.w9L28vVc080088@repo.freebsd.org> In-Reply-To: From: Kyle Evans Date: Wed, 21 Nov 2018 22:02:15 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r339516 - head/sys/cddl/dev/dtrace/powerpc To: Justin Hibbits Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Li-Wen Hsu Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 7FE648857D X-Spamd-Result: default: False [1.35 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_LONG(0.39)[0.389,0]; NEURAL_SPAM_MEDIUM(0.54)[0.537,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_SPAM_SHORT(0.42)[0.425,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 04:02:29 -0000 On Wed, Nov 21, 2018 at 9:42 PM Kyle Evans wrote: > > On Sat, Oct 20, 2018 at 9:09 PM Justin Hibbits wrote: > > > > Author: jhibbits > > Date: Sun Oct 21 02:08:57 2018 > > New Revision: 339516 > > URL: https://svnweb.freebsd.org/changeset/base/339516 > > > > Log: > > powerpc/dtrace: Use explicit bit numbers to mask out PSL_EE > > > > There seems to be a race in CI, such that dtrace_asm.S might be assembled > > before the genassym is completed. This causes a build failure when PSL_EE > > doesn't exist, and is read as 0. Get around this by explicitly specifying > > the bits in the mask instead. > > > > Hi, > > CI on the stable/12 branch still hits this, so I'm tempted to MFC this > if you don't object. OTOH, the correct solution should be a > `dependency "genassym.o"` in ^/sys/conf/files.powerpc for > dtrace_asm.S, no? > Sorry, that should have read "genassym.inc" -- my naive understanding of 'dependency' is that config(8) will turn it directly into a makefile dependency that will alleviate this.