From nobody Fri Jan 12 16:41:07 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TBS373bpbz577ht; Fri, 12 Jan 2024 16:41:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TBS371khxz4VrZ; Fri, 12 Jan 2024 16:41:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705077667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rzvKU1Wog2lPQWgYMJJz9AecRXDm/HRsBjCjW3THDo8=; b=Ciy6JTescqkMJ/45L8p8p1IzyFEzfZLhC5duzsf9Z7D6WCMzk/t+r59eToFsoICzputhNz LCRJ4wN8N8M/aWOyUhXa06Dv1uTQXbmyBcvr6sx7LYaE4wYjVN2nv7gJ1il1L8C6xziPT+ Xp4R1YNfMeROhguq5MIc5iOrfKwcrXteslIiLA5iijWBMbgl+o1iIpMM45Kh7HnJzmQW94 mtze6ElU57fEvRMrpiaLik1borrbxa0w78YpOnLWYc26YrY7Kn50JqATMZz8eQ6ry20DxJ wYqsmbS/EDDrfAuMbu+L8EplhxLywpaNUWFDpouZh3uqjzBTJKLvjZ27vZetcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705077667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rzvKU1Wog2lPQWgYMJJz9AecRXDm/HRsBjCjW3THDo8=; b=FB0jyklSzbGbgSDwlSE6GMRtbYr4Cf8zvmW3JHr1g/NQzIDZTOJkG4++HXqkrbaClBRquP aXG0XkEdL6NGnjmV59VmU6JAfDpYgS6MEhzq9y03prp1rebGvv6SuFuhsO2hyDJYXDAuq8 HEzNb3OsWFFB+3YOuQEnRcAB5p5Ij+IZTNFxjjvIuSg3zV7O1iyPiilWKIcu1gdyJudOB9 Od/JmOrJrtAZB3KidOKxNNLptXtzyGjOgqtbRAJg/Kq9Ga5OIumzxJmGTHLWbsK3VchYhP RCKAr49uA5CeRkKfFhGD+adpKDFysj3yww9MV2DOI/3l50xNE9RT35gd7Ioc6Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705077667; a=rsa-sha256; cv=none; b=idzXLY3Rr6eTo0N406R5GAhJi/5Nto9xA4YFqOgYxHbqcVPBsViyFo6PxSgO1wcWb2EZ2T ys/XN2UsAYhV8axCC80MxK6jMegYu1ZvFQUSUOFr0p+9o9MDVhKsu9eZYkHXzIBzdnT6tW yu0K4VFI5CG515hZNCgMyCUXOK87d4riDWgP16R88L3piBfa0G0QFycgO9Ulzy+qgt8sYa oe+sI+7utDFXuT9S/Uoz7b4vlYFBjAOYrcgwRX+eSLghOhX+cdkxTSKdLtCXRnZV/bYzkl SvuZo338ukJxEIE92opj9hE4RPrFw7lLmPc4Ej+akU6wU0bQeKSFPTH+Lch1tg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TBS370qyKz18QP; Fri, 12 Jan 2024 16:41:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40CGf7mV074858; Fri, 12 Jan 2024 16:41:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40CGf7Q2074855; Fri, 12 Jan 2024 16:41:07 GMT (envelope-from git) Date: Fri, 12 Jan 2024 16:41:07 GMT Message-Id: <202401121641.40CGf7Q2074855@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?= Subject: git: 1e25eb287f3f - main - login: Missed an instance of getpwnam(). List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1e25eb287f3fdd763df98065dbf2e1eb201e4000 Auto-Submitted: auto-generated The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=1e25eb287f3fdd763df98065dbf2e1eb201e4000 commit 1e25eb287f3fdd763df98065dbf2e1eb201e4000 Author: Dag-Erling Smørgrav AuthorDate: 2024-01-12 16:40:55 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2024-01-12 16:40:55 +0000 login: Missed an instance of getpwnam(). Fixes: a3d80dd8aa6ac15877e00102ab174b417ac81d79 MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: allanjude Differential Revision: https://reviews.freebsd.org/D43423 --- usr.bin/login/login.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/usr.bin/login/login.c b/usr.bin/login/login.c index 5b4fa55dc541..6a0c6a5b6bbc 100644 --- a/usr.bin/login/login.c +++ b/usr.bin/login/login.c @@ -704,8 +704,10 @@ auth_pam(void) pam_err = pam_get_item(pamh, PAM_USER, &item); if (pam_err == PAM_SUCCESS) { tmpl_user = (const char *)item; - if (strcmp(username, tmpl_user) != 0) - pwd = getpwnam(tmpl_user); + if (strcmp(username, tmpl_user) != 0) { + (void)getpwnam_r(tmpl_user, &pwres, pwbuf, + sizeof(pwbuf), &pwd); + } } else { pam_syslog("pam_get_item(PAM_USER)"); }