From owner-cvs-src@FreeBSD.ORG  Mon Jul  5 02:34:35 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id AE6D416A4CE; Mon,  5 Jul 2004 02:34:35 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A7F9F43D2F; Mon,  5 Jul 2004 02:34:35 +0000 (GMT)
	(envelope-from bms@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i652YZ9Q068559;
	Mon, 5 Jul 2004 02:34:35 GMT
	(envelope-from bms@repoman.freebsd.org)
Received: (from bms@localhost)
	by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i652YZLq068558;
	Mon, 5 Jul 2004 02:34:35 GMT
	(envelope-from bms)
Message-Id: <200407050234.i652YZLq068558@repoman.freebsd.org>
From: Bruce M Simpson <bms@FreeBSD.org>
Date: Mon, 5 Jul 2004 02:34:35 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/pci if_xl.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Jul 2004 02:34:35 -0000

bms         2004-07-05 02:34:35 UTC

  FreeBSD src repository

  Modified files:
    sys/pci              if_xl.c 
  Log:
  Reintroduce and clean up locking in xl(4).
  
   - Eliminate the use of a recursive mutex.
   - Mark the driver as INTR_MPSAFE.
   - Split the default media choice code out into xl_choose_media() to
     avoid making poor assumptions about the state of the lock during attach.
   - The miibus upcall/downcall paths may still be racy.
     Change to commented-out locking assertions there for now.
   - Tested with nfsclient, routed, ssh, ntp, dhclient and quagga bgpd.
   - This needs SMP test coverage. I do not have such resources.
  
  Tested on:      UP, !debug.mpsafenet && debug.mpsafenet
  Hardware:       3C905B-TX (0x905510b7)
  
  Revision  Changes    Path
  1.177     +178 -88   src/sys/pci/if_xl.c