From owner-dev-commits-ports-main@freebsd.org Fri Jun 4 12:46:11 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A461D64E4DE; Fri, 4 Jun 2021 12:46:11 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FxMvQ5Dl4z3NK7; Fri, 4 Jun 2021 12:46:10 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id 309F7A2F8B; Fri, 4 Jun 2021 14:46:01 +0200 (CEST) Date: Fri, 4 Jun 2021 14:45:59 +0200 From: Piotr Kubaj To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5d304c338aba - main - games/fheroes2: update to 0.9.4 Message-ID: References: <202106040953.1549rbHY052844@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JTvxSDaMpVz4w+/B" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4FxMvQ5Dl4z3NK7 X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.36 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEFALL_USER(0.00)[pkubaj]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; MID_RHS_NOT_FQDN(0.50)[]; ARC_NA(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:46.248.190.61]; SPAMHAUS_ZRD(0.00)[46.248.190.61:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RBL_DBL_DONT_QUERY_IPS(0.00)[46.248.190.61:from]; NEURAL_HAM_LONG(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[anongoth.pl,reject]; NEURAL_HAM_SHORT(-0.96)[-0.955]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main] X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2021 12:46:11 -0000 --JTvxSDaMpVz4w+/B Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 21-06-04 10:06:18, Alexey Dokuchaev wrote: > On Fri, Jun 04, 2021 at 09:53:37AM +0000, Piotr Kubaj wrote: > > commit 5d304c338abaef672b8392ff2d2d0b554106950c > >=20 > > games/fheroes2: update to 0.9.4 > > =20 > > @@ -8,20 +8,15 @@ COMMENT=3D Free implementation of Heroes of Might and= Magic II engine > > LICENSE=3D GPLv2 > > LICENSE_FILE=3D ${WRKSRC}/LICENSE > > =20 > > -LIB_DEPENDS=3D libtinyxml.so:textproc/tinyxml > > +LIB_DEPENDS=3D libpng16.so:graphics/png >=20 > It should be spelled as ``libpng.so:graphics/png'', without 16. Thanks for info. >=20 > > -LDFLAGS+=3D -ltinyxml > > -MAKE_ENV=3D WITHOUT_BUNDLED_LIBS=3D1 >=20 > So, what happened to TinyXML dependency? Is it no longer needed, > or bundled version is used now for some reason? This wasn't > mentioned in the commit log. The bundled one is used, port switched to cmake, which uses pkgconfig for t= inyxml detection, but tinyxml doesn't provide a pc file for pkgconfig, so t= hat fails. >=20 > > +PLIST_FILES=3D bin/${PORTNAME} \ > > + ${DOCSDIR}/README.txt \ > > + ${DOCSDIR}/changelog.txt Thanks for info. >=20 > Docfiles should probably be listed as PORTDOCS, not be part of > the PLIST_FILES. >=20 > ./danfe --JTvxSDaMpVz4w+/B Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmC6IIcACgkQelmbhSCD nJ3Gzg/9G5S1cLuamCoATSxM5DiffGAz5I6NwNRfYc9dWMnxNwNpMqkvcMpBSF2e H9C/cNfhGuq91P8QcsPYGxCWUwOO8q2hAgAiULs4lsermYzkW8a8jKLuib9D+ji+ 6TWQ8AIvF9VplmMrtug0uPm21NiSdY6vdAWySPt0hKVD+J4jR5DIxDx/xUpJQ+7Y mvNAO8UUnh2AatrfNOUne5mZqwraoTTPbhc53IP7p3YhHlK1IYL2jDAv5tyhRxE3 pVkeXvLdm15S5xko5Jn4LRl0GVAtFQDJ4VHd2y9Sf/MK/MKXwbhmhgy1jdh/U4iX /aaRT6vB1DZgG6KQFD4yr616Oi44n6w+8QyoPphEYZ4UPhq2IvMryZOqR0QZKodN 4BPCG3sH3f3vWaZP1hp3Mb2BE0lKwVPk8ooUDG3kTATvuJmhA2CHXVBmL4gYTwel gmQTTtHNHckYE3h73RBy5u/IZHwT9+xQcIvIILoif0a2keIQqaoopWebO248MLDJ cqlsKFtm+G4NeKohsjx8VDva46Pufd/Opf7oyU80V0mXCkQ5a9psTbDROgSTGfBZ vEZ8Tw/H4AmV+InM7BxFvnOdFHhCregxnfsb64fH7gnCDVjTPHPbrGzEFKMLylPL SpTyAw0nJTQQdjTP3izl07RFv5V/vj6A59es5rnitI/w4Ljwe+4= =FKp8 -----END PGP SIGNATURE----- --JTvxSDaMpVz4w+/B--