From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Nov 1 22:10:02 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B49EF106568B for ; Sun, 1 Nov 2009 22:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8F0E68FC22 for ; Sun, 1 Nov 2009 22:10:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nA1MA1G8019711 for ; Sun, 1 Nov 2009 22:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nA1MA1tA019710; Sun, 1 Nov 2009 22:10:01 GMT (envelope-from gnats) Resent-Date: Sun, 1 Nov 2009 22:10:01 GMT Resent-Message-Id: <200911012210.nA1MA1tA019710@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Aragon Gouveia Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3423A106566B for ; Sun, 1 Nov 2009 22:04:10 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 22F3E8FC0A for ; Sun, 1 Nov 2009 22:04:10 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nA1M49J2080447 for ; Sun, 1 Nov 2009 22:04:09 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id nA1M49Wn080445; Sun, 1 Nov 2009 22:04:09 GMT (envelope-from nobody) Message-Id: <200911012204.nA1M49Wn080445@www.freebsd.org> Date: Sun, 1 Nov 2009 22:04:09 GMT From: Aragon Gouveia To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/140175: [patch] mail/ssmtp CRAM-MD5 broken X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2009 22:10:02 -0000 >Number: 140175 >Category: ports >Synopsis: [patch] mail/ssmtp CRAM-MD5 broken >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Nov 01 22:10:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Aragon Gouveia >Release: 8.0-BETA3 >Organization: >Environment: FreeBSD igor.geek.sh 8.0-BETA3 FreeBSD 8.0-BETA3 #0: Thu Sep 17 14:02:41 SAST 2009 root@igor.geek.sh:/usr/obj/usr/src/sys/IGOR amd64 >Description: SSMTP bundles MD5 code with it (md5auth/md5c.c) instead of linking against system libraries, and this bundled code seems to generate broken HMAC-MD5 hashes, which breaks SSMTP's support for CRAM-MD5 SMTP authentication, at least on FreeBSD 8.0. Attached is a patch to the port that unlinks md5auth/md5c.c from the build, and links ssmtp against the system -lmd. >How-To-Repeat: >Fix: Patch attached with submission follows: diff -uNr ssmtp.orig/files/patch-configure ssmtp/files/patch-configure --- ssmtp.orig/files/patch-configure 2003-10-02 01:08:01.000000000 +0200 +++ ssmtp/files/patch-configure 2009-11-01 23:54:36.000000000 +0200 @@ -9,3 +9,16 @@ fi enableval="" +--- configure.orig 2009-11-01 23:52:55.000000000 +0200 ++++ configure 2009-11-01 23:53:42.000000000 +0200 +@@ -1591,7 +1591,8 @@ + #define MD5AUTH 1 + EOF + +- SRCS="$SRCS md5auth/md5c.c md5auth/hmac_md5.c" ++ SRCS="$SRCS md5auth/hmac_md5.c" ++ LIBS="$LIBS -lmd" + fi + enableval="" + + diff -uNr ssmtp.orig/files/patch-md5auth-hmac_md5.c ssmtp/files/patch-md5auth-hmac_md5.c --- ssmtp.orig/files/patch-md5auth-hmac_md5.c 1970-01-01 02:00:00.000000000 +0200 +++ ssmtp/files/patch-md5auth-hmac_md5.c 2009-11-01 23:56:00.000000000 +0200 @@ -0,0 +1,12 @@ +--- md5auth/hmac_md5.c.orig 2009-11-01 23:54:54.000000000 +0200 ++++ md5auth/hmac_md5.c 2009-11-01 23:55:07.000000000 +0200 +@@ -1,7 +1,7 @@ + #include "global.h" +-#include "md5.h" + #include + #include ++#include + + /* + ** Function: hmac_md5 (RFC 2104) + >Release-Note: >Audit-Trail: >Unformatted: