From owner-freebsd-current@freebsd.org Mon Oct 22 17:02:54 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5978D1039415 for ; Mon, 22 Oct 2018 17:02:54 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EC84F852B8 for ; Mon, 22 Oct 2018 17:02:53 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 18F833C475F; Mon, 22 Oct 2018 17:02:53 +0000 (UTC) Date: Mon, 22 Oct 2018 17:02:53 +0000 From: Brooks Davis To: Josh Paetzel Cc: Rick Macklem , FreeBSD Current Subject: Re: which way to update export_args structure? Message-ID: <20181022170253.GC45769@spindle.one-eyed-alien.net> References: <20181003155133.GA57729@spindle.one-eyed-alien.net> <20181008170428.GB9766@spindle.one-eyed-alien.net> <20181022160508.GB45769@spindle.one-eyed-alien.net> <1540226963.490541.1550623304.5D6A95A6@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GRPZ8SYKNexpdSJ7" Content-Disposition: inline In-Reply-To: <1540226963.490541.1550623304.5D6A95A6@webmail.messagingengine.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 17:02:54 -0000 --GRPZ8SYKNexpdSJ7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 22, 2018 at 11:49:23AM -0500, Josh Paetzel wrote: >=20 >=20 > On Mon, Oct 22, 2018, at 11:05 AM, Brooks Davis wrote: >=20 > >=20 > > This is the direction I'd been thinking. FWIW, the usecase is more that > > once you've moved away from the struct it's easy to make incremental > > changes then to use a 32-bit mountd on a 64-bit kernel. Moving toward > > size-independent interfaces helps both causes though. > What is the benefit or usecase for running a 32 bit mountd on a 64 bit ke= rnel? In practice there isn't much of one. If the support had been there, I'd have tried to use it in CheriBSD to run with our 128-bit pointers. The bigger benefit is that now when you want to add something you just add it and handle the case when it's missing rather than having to add another compat shim for old structs. FWIW, I don't feel all that strongly about this case. If you two don't find it worthwhile to make this change, that's entierly reasonable. It just felt like the use of the export struct within the nmount interface was a conversion bandaid vs an intentional decision. -- Brooks --GRPZ8SYKNexpdSJ7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJbzgK8AAoJEKzQXbSebgfAaNEH/AwLxsk9EKHsjVV/OFz8099f qmyuTiZhZFg81cb/bn75PXSdxD6PkbtGZkssywdkBqMeGg9n7R9FL/7De8dWO7tv r8rRsg3HZjBMihcR3A3aUg/I9PhgEWpVvDNf7qjSq8H7SdxAR1DTplR7dHjNv9TW kxI98rsjTAQcaQgqZBmlnWqdaHqwlkrQqkVn5HD7nbz97v+d771FyHb465qbbEgZ theRnT/mWw9vliDjyJ0mKiy5Aocqx2C3/+M9NVAUvP8IcJgUVvFXud4T/oIeruL5 LxiRxem9BkvJa/hTt92l/E8LyYnSuwYgl3HGNASMCIM31bOaI2SpkOoIzIxPwiI= =MIJp -----END PGP SIGNATURE----- --GRPZ8SYKNexpdSJ7--