From owner-svn-ports-head@freebsd.org Wed Jul 3 01:49:12 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 85ADC15E6B72; Wed, 3 Jul 2019 01:49:12 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 29C738456C; Wed, 3 Jul 2019 01:49:12 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 0208D1B8BA; Wed, 3 Jul 2019 01:49:11 +0000 (UTC) Date: Wed, 3 Jul 2019 01:49:11 +0000 From: Alexey Dokuchaev To: Matthias Fechner Cc: Torsten Zuehlsdorff , Palle Girgensohn , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r505245 - in head/databases: postgresql10-client postgresql10-contrib postgresql10-pgtcl postgresql10-server postgresql11-client postgresql11-server postgresql94-server postgresql95-cli... Message-ID: <20190703014911.GA54700@FreeBSD.org> References: <201906272128.x5RLS0Uv072609@repo.freebsd.org> <899f2367-828a-9eca-dfaa-e34a039fcdac@toco-domains.de> <20190629155606.GB97932@FreeBSD.org> <6ff9ed1f-1597-bc72-6ed2-e0bb634af8f7@fechner.net> <20190630091359.GB59213@FreeBSD.org> <89601d0c-3b73-b01e-fdc5-49f34fd8bf9e@fechner.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89601d0c-3b73-b01e-fdc5-49f34fd8bf9e@fechner.net> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 29C738456C X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.86 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.994,0]; NEURAL_HAM_SHORT(-0.87)[-0.867,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jul 2019 01:49:12 -0000 On Tue, Jul 02, 2019 at 10:04:35PM +0200, Matthias Fechner wrote: > Am 30.06.2019 um 11:13 schrieb Alexey Dokuchaev: > > I tried to see what had changed but could only find version bump from 9.2 > > to 9.6 in commits like these: > > > > https://gitlab.com/gitlab-org/gitlab-ce/commit/b609c8f650ca9854d12edbf623f2419c216e73a7 > > https://gitlab.com/gitlab-org/gitlab-ce/commit/e1294022875138b40db7d34a9f33ac9f4a7dc655 > > > > I'd try to lower those number to 9.5, I'd expect with high probability > > things would work just as fine. > > if I remember correctly it will break with postgresql < 9.6 if you use a > more complex structure for groups. That's why I don't like separate commits in code/docs area, at least when one commit (documenting 9.2->9.6 requirement) does not reference the actual code commit which makes use of new features: no one can/wish to pin-point the exact issue later, just giving those IIRC's. > You can check the manual on: > https://gitlab.fechner.net/mfechner/Gitlab-docu > > to see at which version I changed the version requirements. If you mean this commit: https://gitlab.fechner.net/mfechner/Gitlab-docu/commit/694fc5875d2d7ac9b285fdd706f318989e633dc6 then I don't see how it explains why 9.5 doesn't cut it, while 9.6 does. Anyway, I didn't really want to argue about this, I don't use GitLab and don't care about it (now even more, seeing how well it's being developed and documented). I jumped in mostly because bumping default PG version to 11 in FreeBSD had raised my brows a bit. :-) Peace, ./danfe