From owner-freebsd-audit  Tue May 28  2:50:34 2002
Delivered-To: freebsd-audit@freebsd.org
Received: from turbine.trit.org (turbine.trit.org [63.198.170.141])
	by hub.freebsd.org (Postfix) with ESMTP id B09DC37B405
	for <audit@freebsd.org>; Tue, 28 May 2002 02:50:32 -0700 (PDT)
Received: from turbine.trit.org (localhost [127.0.0.1])
	by turbine.trit.org (Postfix) with ESMTP id 1A2D73E5E
	for <audit@freebsd.org>; Tue, 28 May 2002 09:50:30 +0000 (UTC)
To: audit@freebsd.org
Subject: Re: VT_LOCKSWITCH 
In-Reply-To: <20020528124559.C374@straylight.oblivion.bg>; from roam@ringlet.net on "Tue, 28 May 2002 12:45:59 +0300"
Date: Tue, 28 May 2002 09:50:30 +0000
From: Dima Dorfman <dima@trit.org>
Message-Id: <20020528095031.1A2D73E5E@turbine.trit.org>
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

Peter Pentchev <roam@ringlet.net> wrote:
> On Tue, May 28, 2002 at 08:54:20AM +0000, Dima Dorfman wrote:
> > +void
> > +set_lockswitch(char *arg)
> > +{
> > +	int data;
> > +
> > +	if (!strcmp(arg, "off"))
> > +		data =3D 0x01;
> > +	else if (!strcmp(arg, "on"))
> > +		data =3D 0x02;
> > +	else {
> > +		warnx("argument to -S must either on or off");
> 
> A very, very minor nit: should this not be 'must *be* either on or off'? :)

Either that or "must either be".  The same error exists in two other
places in vidcontrol (set_lockswitch() is mostly pasted from
set_mouse()); I'll fix all of them in a separate commit.  Thanks for
catching this!

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message