From owner-svn-src-all@FreeBSD.ORG Sat Dec 21 00:31:02 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 95B2D677; Sat, 21 Dec 2013 00:31:02 +0000 (UTC) Received: from mail-qc0-x22f.google.com (mail-qc0-x22f.google.com [IPv6:2607:f8b0:400d:c01::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1E11A17D4; Sat, 21 Dec 2013 00:31:02 +0000 (UTC) Received: by mail-qc0-f175.google.com with SMTP id e9so2873296qcy.6 for ; Fri, 20 Dec 2013 16:31:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=LdisjTC1n5NPwS1gKFB0ZQ1SB1ouS85IyN61pxQTvyc=; b=Vnd9c09qsAGSUNTM2veH4dGgYy0m40klYKXth/6vgAuhX9Oge9KaXiQhlsmTU0WOy3 kKSKDVLeIy2h+hwiyioWOuIxy2k0/mgceBVDXDC6ZRC20hvO+keH6MwOUEnVTh9x9OJQ urlR6GLLFs8bLMi2/9U5JxYKChrquysOTA/FOUvqqrdFanbkViABeF1ufj/osYNrfmev gSRDuX92T5hoaPd6fIYyCARfgKY53sCvpDl/xsbXZuP85V9KVKDcDvI0Vto9wpdzp7kD rSo9zyfsscT9bzFqcoGn3vdSJo72b+JWJWk4RPfRW7FoBbMC6it5n+APtVJb6LfNIsdi yGMg== MIME-Version: 1.0 X-Received: by 10.224.135.71 with SMTP id m7mr19777048qat.10.1387585861172; Fri, 20 Dec 2013 16:31:01 -0800 (PST) Received: by 10.224.130.194 with HTTP; Fri, 20 Dec 2013 16:31:01 -0800 (PST) In-Reply-To: <201312202318.rBKNIFbS097430@svn.freebsd.org> References: <201312202318.rBKNIFbS097430@svn.freebsd.org> Date: Sat, 21 Dec 2013 08:31:01 +0800 Message-ID: Subject: Re: svn commit: r259668 - head/sys/cddl/dev/fbt From: Howard Su To: Justin Hibbits Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Dec 2013 00:31:02 -0000 On Saturday, December 21, 2013, Justin Hibbits wrote: > Author: jhibbits > Date: Fri Dec 20 23:18:14 2013 > New Revision: 259668 > URL: http://svnweb.freebsd.org/changeset/base/259668 > > Log: > Fix a couple bugs in FBT PowerPC. Clamp the size to a 'instruction > size' not > 'byte size', and fix a typo. > > MFC after: 2 weeks > > Modified: > head/sys/cddl/dev/fbt/fbt_powerpc.c > > Modified: head/sys/cddl/dev/fbt/fbt_powerpc.c > > ============================================================================== > --- head/sys/cddl/dev/fbt/fbt_powerpc.c Fri Dec 20 21:31:50 2013 > (r259667) > +++ head/sys/cddl/dev/fbt/fbt_powerpc.c Fri Dec 20 23:18:14 2013 > (r259668) > @@ -219,7 +219,7 @@ fbt_provide_module_function(linker_file_ > return (0); > > instr = (u_int32_t *) symval->value; > - limit = (u_int32_t *) (symval->value + symval->size); > + limit = (u_int32_t *) (symval->value + symval->size / > sizeof(u_int32_t)); > > This change doesn't look right to me. symval->value is caddr_t (char*). why add instruction size to it? > for (; instr < limit; instr++) > if (*instr == FBT_MFLR_R0) > @@ -278,7 +278,7 @@ again: > instr++; > > for (j = 0; j < 12 && instr < limit; j++, instr++) { > - if ((*instr == FBT_BCTR) || (*instr == FBT_BLR) | > + if ((*instr == FBT_BCTR) || (*instr == FBT_BLR) || > FBT_IS_JUMP(*instr)) > break; > } > _______________________________________________ > svn-src-head@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org > " > -- -Howard