From owner-svn-ports-all@freebsd.org  Thu Apr 13 15:00:58 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E514D3B7E5;
 Thu, 13 Apr 2017 15:00:58 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 520E21E26;
 Thu, 13 Apr 2017 15:00:58 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 77E3274EE; Thu, 13 Apr 2017 15:00:57 +0000 (UTC)
Date: Thu, 13 Apr 2017 15:00:57 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Maxim Sobolev <sobomax@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r438413 - in head/devel: . debugedit debugedit/files
Message-ID: <20170413150057.GB86375@FreeBSD.org>
References: <201704122049.v3CKnQS9032104@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201704122049.v3CKnQS9032104@repo.freebsd.org>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Apr 2017 15:00:58 -0000

On Wed, Apr 12, 2017 at 08:49:26PM +0000, Maxim Sobolev wrote:
> New Revision: 438413
> URL: https://svnweb.freebsd.org/changeset/ports/438413
> 
> Log:
>   Add debugedit - ELF file debug information extractor and editor.
>   
> ...
> +PORTVERSION=	20170411.1
> +#PORTREVISION=	1

Strange port version (2017.04.11.1 would look more consistent), and
polluting the Makefile with commented out useless lines is bad. :-)

> +USE_GITHUB=	yes
> +GH_ACCOUNT=	CoryXie
> +GH_TAGNAME=	b1e81ec
> +
> +USES=		gmake
> +
> +WRKSRC=		${WRKDIR}/DebugEdit-${GH_TAGNAME}

I presume misused USE_GITHUB was already fixed earlier.

> +	${INSTALL_MAN} ${WRKSRC}/README.txt ${STAGEDIR}${DOCSDIR}

INSTALL_MAN is not for docs, it's for manpages.  Also, when installing docs,
it's a good idea to OPTIONS_DEFINE+=DOCS and use {do|post}-install-DOCS-on
special helper target.

> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/debugedit/files/patch-Makefile	Wed Apr 12 20:49:26 2017	(r438413)
> @@ -0,0 +1,12 @@
> +
> +$FreeBSD$
> +
> +--- Makefile.orig	2017-04-11 06:09:46 UTC
> ++++ Makefile
> +@@ -1,5 +1,5 @@
> + CC?=gcc
> +-CFLAGS+=-lelf -lpopt -Wall
> ++CFLAGS+=-lelf -lpopt -Wall -I${LOCALBASE}/include -L${LOCALBASE}/lib

Have you tried to use USES+=localbase instead of patching this Makefile?

> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/debugedit/pkg-plist	Wed Apr 12 20:49:26 2017	(r438413)
> @@ -0,0 +1,2 @@
> +bin/debugedit
> +%%DOCSDIR%%/README.txt

We typically discourage two-line pkg-plist files.  This should've been:

PLIST_FILES=	bin/debugedit
PORTDOCS=	README.txt

./danfe