Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 Feb 2020 21:41:02 +0000 (UTC)
From:      Niclas Zeising <zeising@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r526592 - head/Mk/Uses
Message-ID:  <202002202141.01KLf2fw016257@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: zeising
Date: Thu Feb 20 21:41:02 2020
New Revision: 526592
URL: https://svnweb.freebsd.org/changeset/ports/526592

Log:
  xorg ports: Add -Werror=uninitialized to CFLAGS
  
  Add -Werror=uninitialized to CFLAGS for ports specifying
  xorg-cat:[driver,lib,xserver].  There has been cases in the past when use of
  uninitialized variables have caused crashes, so add this as an error to
  detect it early.

Modified:
  head/Mk/Uses/xorg-cat.mk

Modified: head/Mk/Uses/xorg-cat.mk
==============================================================================
--- head/Mk/Uses/xorg-cat.mk	Thu Feb 20 21:37:46 2020	(r526591)
+++ head/Mk/Uses/xorg-cat.mk	Thu Feb 20 21:41:02 2020	(r526592)
@@ -124,6 +124,7 @@ USE_XORG+=      xorg-macros
 
 .  elif ${_XORG_CAT} == driver
 USE_XORG+=	xi xorg-server xorgproto
+CFLAGS+=	-Werror=uninitialized
 .    if ${_XORG_BUILDSYS} == meson
 # Put special stuff for meson here
 .    else
@@ -150,6 +151,7 @@ PLIST_FILES+=	"@comment ${FONTSDIR}/fonts.dir" \
 .    endif
 
 .  elif ${_XORG_CAT} == lib
+CFLAGS+=	-Werror=uninitialized
 .include "${USESDIR}/pathfix.mk"
 .    if ${_XORG_BUILDSYS} == meson
 # put meson stuff here
@@ -165,6 +167,7 @@ CONFIGURE_ARGS+=--enable-malloc0returnsnull
 
 .  elif ${_XORG_CAT} == xserver
 DISTNAME?=	xorg-server-${PORTVERSION}
+CFLAGS+=	-Werror=uninitialized
 .include "${USESDIR}/pathfix.mk"
 .    if ${_XORG_BUILDSYS} == meson
 # put meson stuff here



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202002202141.01KLf2fw016257>