From owner-svn-src-all@freebsd.org  Wed Oct  7 22:02:52 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 970A89D1C68;
 Wed,  7 Oct 2015 22:02:52 +0000 (UTC)
 (envelope-from cse.cem@gmail.com)
Received: from mail-yk0-f182.google.com (mail-yk0-f182.google.com
 [209.85.160.182])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2192483D;
 Wed,  7 Oct 2015 22:02:52 +0000 (UTC)
 (envelope-from cse.cem@gmail.com)
Received: by ykdg206 with SMTP id g206so32046182ykd.1;
 Wed, 07 Oct 2015 15:02:51 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=mime-version:reply-to:in-reply-to:references:date:message-id
 :subject:from:to:cc:content-type;
 bh=IdSJk66yo76mTN8lxEODuW7cwfEnqw1oIwtzaqgNXuA=;
 b=D/5pzDcWfE1UIWM1sM+B5ZGGrsv9N0M4+zheoRGftRLqOUbajb45G+dI/NbuusInUU
 UyyMhZN+cH2h6TA0lVre1qsCR18pZuvhWX7v0DsHBK88QHmZEEAWRyxdrA7AgV7+ILjc
 pBev93AFjNYsxSgcgmeTKMixE/AAfyHY0k4r07KxEHSbFLkcJbEvleFG0ADzfNDe+KzC
 ZCbPJ4eUd96VAoq+cr4xRO6OHvthux/35PRX1mql+k9LX2KaF6b3d9bQH8rBCkNtGDTZ
 jO/bQGMWUn3cWivAKV9Olq5wr/VrYmeR22dagqQPj2pmtcqN+QA0pA0MZWNYpZ6QO0h4
 iapw==
X-Received: by 10.129.51.23 with SMTP id z23mr2918399ywz.198.1444254963131;
 Wed, 07 Oct 2015 14:56:03 -0700 (PDT)
Received: from mail-yk0-f174.google.com (mail-yk0-f174.google.com.
 [209.85.160.174])
 by smtp.gmail.com with ESMTPSA id w184sm14733285ywe.50.2015.10.07.14.56.02
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 07 Oct 2015 14:56:03 -0700 (PDT)
Received: by ykdz138 with SMTP id z138so31925777ykd.2;
 Wed, 07 Oct 2015 14:56:02 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.129.159.194 with SMTP id w185mr2911294ywg.272.1444254962681; 
 Wed, 07 Oct 2015 14:56:02 -0700 (PDT)
Reply-To: cem@FreeBSD.org
Received: by 10.37.60.198 with HTTP; Wed, 7 Oct 2015 14:56:02 -0700 (PDT)
In-Reply-To: <201510070928.t979SsMQ057994@repo.freebsd.org>
References: <201510070928.t979SsMQ057994@repo.freebsd.org>
Date: Wed, 7 Oct 2015 14:56:02 -0700
Message-ID: <CAG6CVpVdOeUFg3cSffTKcn9T2SGvLMhERiesecwZ6aoeAjpLjA@mail.gmail.com>
Subject: Re: svn commit: r288984 - head/sbin/sysctl
From: Conrad Meyer <cem@FreeBSD.org>
To: Baptiste Daroussin <bapt@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Oct 2015 22:02:52 -0000

On Wed, Oct 7, 2015 at 2:28 AM, Baptiste Daroussin <bapt@freebsd.org> wrote:
> --- head/sbin/sysctl/sysctl.c   Wed Oct  7 09:12:49 2015        (r288983)
> +++ head/sbin/sysctl/sysctl.c   Wed Oct  7 09:28:54 2015        (r288984)
> @@ -276,7 +276,11 @@ parse(const char *string, int lineno)
>                 if (qflag)
>                         return (1);
>                 else {
> -                       warn("unknown oid '%s'%s", bufp, line);
> +                       if (errno == ENOENT) {
> +                               warnx("unknown oid '%s'%s", bufp, line);
> +                       } else {
> +                               warn("unknown oid '%s'%s", bufp, line);

Is "unknown oid" an appropriate warning for errno != ENOENT?

> +                       }
>                         return (1);
>                 }
>         }
>

Best,
Conrad