From owner-svn-src-stable-12@freebsd.org Thu Nov 15 20:47:48 2018 Return-Path: Delivered-To: svn-src-stable-12@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 704AA1109320; Thu, 15 Nov 2018 20:47:48 +0000 (UTC) (envelope-from v.maffione@gmail.com) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D1EA57D942; Thu, 15 Nov 2018 20:47:47 +0000 (UTC) (envelope-from v.maffione@gmail.com) Received: by mail-qk1-x72b.google.com with SMTP id d19so34016410qkg.5; Thu, 15 Nov 2018 12:47:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ny0fKgeVK0clqKnpfIDtREWUZuKNcSpefUZJP7dieWE=; b=iDXTdUI84KOOOaC7SKQR927eto0tZ4wwVknTbOR+Ds8U9nl4jekJIyicxK2hvMzNnj FXPA3QitkPxEGfVHWf/GCYXvR6ixbqC0eRJaGIT8Sn+fPtdT0euH4VWAluAgm6Z/xRbE 0yQHyVKJ6FaEQMbxdciGPsbRhBhDDF2mBoOf0LNJw0U5RulfW++dI9cfupMf7A7CFqjY FoeBTugfG3tJjfF3wUsYK3wCMXWrtOwiU2kw8EEbCx9ii8oc754EAJUyBXU0Lm8kqXM5 Myw5xprzMcGY53DT/brwx4pHV9f7qD+OTDhyjw8Movf+17L5PzctCGtiPArmcdFCNaJ7 ZSQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ny0fKgeVK0clqKnpfIDtREWUZuKNcSpefUZJP7dieWE=; b=MFv6PO8l1J27cAYysR+8s2M65SMr0lg2jAjkiWWSdA1Y4vPBXsSsgvCTMnhewq6Cg6 h20T9efz4ze2V6Z8Zs9ohRUzY5+99uAF+zmxe0mMAf/5lpjTsQ6wgwOnNffrRi0t6WmN ogr40evJjNVXoOaoCirpdcw5eulxsS4sFx42HF+kvOoi7YBqUuv2bJfw8AwHNtSmwyv9 KM2et2noYNTnxOzvbWQTJavJV+ouXQ45oE08la92aAtXiOWZUGuunhlESMRC7usqgXAl od8P5ZzU7HZn/H6rxUAILte/ZKZVsacwPIvvVcCeeOUdUEvZhJdDHCJaWx7eavkxOcmX Pzyw== X-Gm-Message-State: AA+aEWYxQ0vEdZIsXtS4w755tIgLtNVQbr5ZnHCCB7UJJI9jPo4r2zyH PeNvPwlFigtWIuIP5Fdwd4xK/7KRDfu/yaa9O/0AGxcO X-Google-Smtp-Source: AJdET5fVdC+CVw8u+sDnunIWfB1hB+6xvXLRAstXLC1fUOzCAMdLWMA3i4Jz42zhvvkmF5fWeKs825tKpjdbTj8sxgs= X-Received: by 2002:ac8:543:: with SMTP id c3mr534852qth.34.1542314867038; Thu, 15 Nov 2018 12:47:47 -0800 (PST) MIME-Version: 1.0 References: <201811151851.wAFIpbA4025094@repo.freebsd.org> <201811152046.wAFKkiNH042882@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201811152046.wAFKkiNH042882@pdx.rh.CN85.dnsmgr.net> From: Vincenzo Maffione Date: Thu, 15 Nov 2018 21:47:35 +0100 Message-ID: Subject: Re: svn commit: r340461 - in stable/12/sys/dev: netmap virtio/network To: rgrimes@freebsd.org Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org X-Rspamd-Queue-Id: D1EA57D942 X-Spamd-Result: default: False [-4.89 / 200.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; IP_SCORE(-0.91)[ipnet: 2607:f8b0::/32(-2.66), asn: 15169(-1.81), country: US(-0.10)]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[b.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.97)[-0.970,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-stable-12@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for only the 12-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 20:47:48 -0000 No worries Cheers, Vincenzo On Thu, Nov 15, 2018, 9:46 PM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net wrote: > > Author: vmaffione > > Date: Thu Nov 15 18:51:37 2018 > > New Revision: 340461 > > URL: https://svnweb.freebsd.org/changeset/base/340461 > > > > Log: > > MFC :r340436 > > > > vtnet: fix netmap support > > > > netmap(4) support for vtnet(4) was incomplete and had multiple bugs. > > This commit fixes those bugs to bring netmap on vtnet in a functional > state. > > > > Changelist: > > - handle errors returned by virtqueue_enqueue() properly (they were > > previously ignored) > > - make sure netmap XOR rest of the kernel access each virtqueue. > > - compute the number of netmap slots for TX and RX separately, > according to > > whether indirect descriptors are used or not for a given virtqueue. > > - make sure sglist are freed according to their type (mbufs or netmap > > buffers) > > - add support for mulitiqueue and netmap host (aka sw) rings. > > - intercept VQ interrupts directly instead of intercepting them in > txq_eof > > and rxq_eof. This simplifies the code and makes it easier to make > sure > > taskqueues are not running for a VQ while it is in netmap mode. > > - implement vntet_netmap_config() to cope with changes in the number > of queues. > > > > Sponsored by: Sunny Valley Networks > > Differential Revision: https://reviews.freebsd.org/D17916 > > Approved by: re (gjb) > > Thank you for getting this merged early, intime for RC1. > > > -- > Rod Grimes > rgrimes@freebsd.org >