Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Jul 2010 17:50:57 +0400
From:      Anonymous <swell.k@gmail.com>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/148754: [patch] Mk/bsd.port.mk: allow using MAKE_JOBS_NUMBER with empty _MAKE_JOBS
Message-ID:  <868w57inr2.fsf@gmail.com>
Resent-Message-ID: <201007191400.o6JE02Jo070232@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         148754
>Category:       ports
>Synopsis:       [patch] Mk/bsd.port.mk: allow using MAKE_JOBS_NUMBER with empty _MAKE_JOBS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 19 14:00:02 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
Some ports may not want to use make(1)'s `-j3' but instead use
MAKE_JOBS_NUMBER for their own jobs.

cf. http://docs.freebsd.org/cgi/mid.cgi?86bpayoj2j.fsf
>How-To-Repeat:
>Fix:
--- a.diff begins here ---
Index: Mk/bsd.port.mk
===================================================================
RCS file: /a/.cvsup/ports/Mk/bsd.port.mk,v
retrieving revision 1.643
diff -u -p -r1.643 bsd.port.mk
--- Mk/bsd.port.mk	15 Jul 2010 14:48:50 -0000	1.643
+++ Mk/bsd.port.mk	19 Jul 2010 13:42:22 -0000
@@ -2294,7 +2301,7 @@ _MAKE_JOBS=		#
 .else
 .if defined(MAKE_JOBS_SAFE) || defined(FORCE_MAKE_JOBS)
 MAKE_JOBS_NUMBER?=	`${SYSCTL} -n kern.smp.cpus`
-_MAKE_JOBS=		-j${MAKE_JOBS_NUMBER}
+_MAKE_JOBS?=		-j${MAKE_JOBS_NUMBER}
 .if defined(FORCE_MAKE_JOBS) && !defined(MAKE_JOBS_SAFE)
 BUILD_FAIL_MESSAGE+=	"You have chosen to use multiple make jobs (parallelization) for all ports.  This port was not tested for this setting.  Please remove FORCE_MAKE_JOBS and retry the build before reporting the failure to the maintainer."
 .endif
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?868w57inr2.fsf>