From owner-freebsd-bugs@freebsd.org Mon Jun 11 23:31:06 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2E61E100E742 for ; Mon, 11 Jun 2018 23:31:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id B892084C70 for ; Mon, 11 Jun 2018 23:31:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 71C7F100E741; Mon, 11 Jun 2018 23:31:05 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 30745100E740 for ; Mon, 11 Jun 2018 23:31:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B8C0284C6B for ; Mon, 11 Jun 2018 23:31:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id E596FF0D7 for ; Mon, 11 Jun 2018 23:31:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w5BNV3ph074815 for ; Mon, 11 Jun 2018 23:31:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w5BNV3J2074814 for bugs@FreeBSD.org; Mon, 11 Jun 2018 23:31:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 228907] VMCI driver: During datagram dispatch if there's no source context then use the current context. Date: Mon, 11 Jun 2018 23:31:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: vdasahar@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 23:31:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228907 Bug ID: 228907 Summary: VMCI driver: During datagram dispatch if there's no source context then use the current context. Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: vdasahar@gmail.com When dispatching a VMCI datagram, if no source context is provided we must = use the current context. Also, it's better to use VMCI_MEMORY_ATOMIC i.e, M_NOW= AIT for memory allocation in datagram_create_hnd. Could you please help get this patch in? --- a/freebsd_driver/src/vmci_datagram.c +++ b/freebsd_driver/src/vmci_datagram.c @@ -160,7 +160,7 @@ datagram_create_hnd(vmci_id resource_id, uint32_t flags, handle =3D VMCI_MAKE_HANDLE(context_id, resource_id); } - entry =3D vmci_alloc_kernel_mem(sizeof(*entry), VMCI_MEMORY_NORMAL); + entry =3D vmci_alloc_kernel_mem(sizeof(*entry), VMCI_MEMORY_ATOMIC); if (entry =3D=3D NULL) { VMCI_LOG_WARNING(LGPFX"Failed allocating memory for datagra= m " "entry.\n"); @@ -457,7 +457,7 @@ vmci_datagram_dispatch_as_guest(struct vmci_datagram *d= g) resource =3D vmci_resource_get(dg->src, VMCI_RESOURCE_TYPE_DATAGRAM= ); if (NULL =3D=3D resource) - return VMCI_ERROR_NO_HANDLE; + return (VMCI_ERROR_NO_HANDLE); retval =3D vmci_send_datagram(dg); vmci_resource_release(resource); @@ -495,6 +495,10 @@ vmci_datagram_dispatch(vmci_id context_id, struct vmci_datagram *dg) return (VMCI_ERROR_INVALID_ARGS); } + /* If no source context then use the current context. */ + if (VMCI_INVALID_ID =3D=3D dg->src.context) + dg->src.context =3D vmci_get_context_id(); + return (vmci_datagram_dispatch_as_guest(dg)); } --=20 You are receiving this mail because: You are the assignee for the bug.=