From owner-svn-src-head@freebsd.org Mon Nov 16 03:23:22 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77067A30275; Mon, 16 Nov 2015 03:23:22 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gold.funkthat.com", Issuer "gold.funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 57B791C9C; Mon, 16 Nov 2015 03:23:22 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.14.5/8.14.5) with ESMTP id tAG3NGP7089984 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 15 Nov 2015 19:23:16 -0800 (PST) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.14.5/8.14.5/Submit) id tAG3NGkQ089983; Sun, 15 Nov 2015 19:23:16 -0800 (PST) (envelope-from jmg) Date: Sun, 15 Nov 2015 19:23:16 -0800 From: John-Mark Gurney To: Alexey Dokuchaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290900 - head/sbin/restore Message-ID: <20151116032316.GJ65715@funkthat.com> References: <201511160129.tAG1Tx0V080628@repo.freebsd.org> <20151116020842.GA5488@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151116020842.GA5488@FreeBSD.org> X-Operating-System: FreeBSD 9.1-PRERELEASE amd64 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (gold.funkthat.com [127.0.0.1]); Sun, 15 Nov 2015 19:23:16 -0800 (PST) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2015 03:23:22 -0000 Alexey Dokuchaev wrote this message on Mon, Nov 16, 2015 at 02:08 +0000: > On Mon, Nov 16, 2015 at 01:29:59AM +0000, John-Mark Gurney wrote: > > New Revision: 290900 > > URL: https://svnweb.freebsd.org/changeset/base/290900 > > > > Log: > > If you backup a large file that is mostly holes, previously we'd issue > > a seek for every block... For large (Exabyte sized files) this would > > issue lots of unneeded seeks, so combine them... > > > > [...] > > @@ -938,14 +953,15 @@ getfile(void (*datafill)(char *, long), > > { > > int i; > > off_t size; > > + long seekpos; > > Briefly reading through tape.c, it looks like `long' is abused here (and in > other places). IMHO we should try to fix these bugs, not add new misuses. I agree... I'll ask if Jan is interested in fixing it, but it may need to be added to the IdeasPage... It'd also be good to have a test of regression tests for restore such that changes can be verified not to break things.. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."