From owner-svn-src-head@FreeBSD.ORG  Mon Feb  4 09:42:38 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id DF8C6B69;
 Mon,  4 Feb 2013 09:42:38 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 928237F9;
 Mon,  4 Feb 2013 09:42:37 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA18041;
 Mon, 04 Feb 2013 11:42:33 +0200 (EET) (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1U2IZN-0008Xk-Bf; Mon, 04 Feb 2013 11:42:33 +0200
Message-ID: <510F8287.7030708@FreeBSD.org>
Date: Mon, 04 Feb 2013 11:42:31 +0200
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130121 Thunderbird/17.0.2
MIME-Version: 1.0
To: Marko Zec <zec@fer.hr>
Subject: Re: svn commit: r246245 - head/sys/netgraph
References: <201302021154.r12Bs0tp030831@svn.freebsd.org>
 <20130204003701.GA1700@oddish> <510F662C.1080007@FreeBSD.org>
 <201302040927.43559.zec@fer.hr>
In-Reply-To: <201302040927.43559.zec@fer.hr>
X-Enigmail-Version: 1.4.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 Mark Johnston <markj@FreeBSD.org>, src-committers@FreeBSD.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Feb 2013 09:42:39 -0000

on 04/02/2013 10:27 Marko Zec said the following:
> On Monday 04 February 2013 08:41:32 Andriy Gapon wrote:
>> +	/* Only ethernet interfaces are of interest. */
>> +	if (ifp->if_type != IFT_ETHER)
>> +		return;
> 
> 
> And what about IFT_FDDI, IFT_XETHER, IFT_ISO88025, IFT_L2VLAN, IFT_BRIDGE, 
> IFT_ARCNET, IFT_IEEE8023ADLAG, IFT_IEEE80211?

Oh, I didn't realize that many drivers changed if_type after if_alloc.
Honestly, the networking code is not my strong skill, I ventured here only
because nobody else did...

So what do you suggest?  if_alloctype or a different approach?
I'd like to prevent if_l2com being mis-interpreted as struct arpcom.

-- 
Andriy Gapon