From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Apr 13 14:50:02 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E98E61065679 for ; Sun, 13 Apr 2008 14:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B96648FC25 for ; Sun, 13 Apr 2008 14:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m3DEo1SF053737 for ; Sun, 13 Apr 2008 14:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m3DEo1aZ053736; Sun, 13 Apr 2008 14:50:01 GMT (envelope-from gnats) Resent-Date: Sun, 13 Apr 2008 14:50:01 GMT Resent-Message-Id: <200804131450.m3DEo1aZ053736@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Scott Mitchell Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4C710106566B for ; Sun, 13 Apr 2008 14:44:24 +0000 (UTC) (envelope-from scott@fishballoon.org) Received: from queueout01-winn.ispmail.ntl.com (queueout01-winn.ispmail.ntl.com [81.103.221.31]) by mx1.freebsd.org (Postfix) with ESMTP id A0D0D8FC2B for ; Sun, 13 Apr 2008 14:44:23 +0000 (UTC) (envelope-from scott@fishballoon.org) Received: from aamtaout02-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com with ESMTP id <20080413143447.LWBE13584.mtaout01-winn.ispmail.ntl.com@aamtaout02-winn.ispmail.ntl.com> for ; Sun, 13 Apr 2008 15:34:47 +0100 Received: from llama.fishballoon.org ([81.101.131.46]) by aamtaout02-winn.ispmail.ntl.com with ESMTP id <20080413143359.DTCF17393.aamtaout02-winn.ispmail.ntl.com@llama.fishballoon.org> for ; Sun, 13 Apr 2008 15:33:59 +0100 Received: from tuatara.fishballoon.org ([192.168.1.6]:59293) by llama.fishballoon.org with esmtp (Exim 4.66 (FreeBSD)) (envelope-from ) id 1Jl3FB-000GrF-55 for FreeBSD-gnats-submit@freebsd.org; Sun, 13 Apr 2008 15:31:45 +0100 Received: (from scott@localhost) by tuatara.fishballoon.org (8.14.2/8.14.2/Submit) id m3DEViex002853; Sun, 13 Apr 2008 15:31:44 +0100 (BST) (envelope-from scott) Message-Id: <200804131431.m3DEViex002853@tuatara.fishballoon.org> Date: Sun, 13 Apr 2008 15:31:44 +0100 (BST) From: Scott Mitchell To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/122724: [PATCH] security/pwauth: make MIN_UNIX_UID configurable X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Scott Mitchell List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Apr 2008 14:50:02 -0000 >Number: 122724 >Category: ports >Synopsis: [PATCH] security/pwauth: make MIN_UNIX_UID configurable >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Apr 13 14:50:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Scott Mitchell >Release: FreeBSD 7.0-RELEASE i386 >Organization: >Environment: System: FreeBSD tuatara.fishballoon.org 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24 19:59:52 UTC 2008 root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: The security/pwauth port uses the MIN_UNIX_UID macro to restrict the range of UIDs it will authenticate - this defaults to 500 but is changed to 1000 by the port. The port Makefile's post-patch action looks like it was intended to allow this value to be configurable, but as written it doesn't work. The attached patch allows MIN_UNIX_UID to be set from the MINUID make variable, still with a default of 1000. >How-To-Repeat: >Fix: diff -cr pwauth.orig/Makefile pwauth/Makefile *** pwauth.orig/Makefile 2008-04-13 15:12:44.000000000 +0100 --- pwauth/Makefile 2008-04-13 15:15:21.000000000 +0100 *************** *** 21,30 **** .include WWWUID!= ${ID} -u ${WWWOWN} post-patch: @${REINPLACE_CMD} "s/%%UIDS%%/${WWWUID}/ ; \ ! s/%%MINUID%%/1000/" ${WRKSRC}/config.h do-install: -@${MKDIR} -p ${PREFIX}/bin --- 21,31 ---- .include WWWUID!= ${ID} -u ${WWWOWN} + MINUID?= 1000 post-patch: @${REINPLACE_CMD} "s/%%UIDS%%/${WWWUID}/ ; \ ! s/%%MINUID%%/${MINUID}/" ${WRKSRC}/config.h do-install: -@${MKDIR} -p ${PREFIX}/bin diff -cr pwauth.orig/files/patch-config.c pwauth/files/patch-config.c *** pwauth.orig/files/patch-config.c 2008-04-13 15:13:21.000000000 +0100 --- pwauth/files/patch-config.c 2008-04-13 15:14:19.000000000 +0100 *************** *** 39,45 **** */ -#define MIN_UNIX_UID 500 /**/ ! +#define MIN_UNIX_UID 1000 /**/ /* If IGNORE_CASE is defined, the login given is checked in two different --- 39,45 ---- */ -#define MIN_UNIX_UID 500 /**/ ! +#define MIN_UNIX_UID %%MINUID%% /**/ /* If IGNORE_CASE is defined, the login given is checked in two different >Release-Note: >Audit-Trail: >Unformatted: