From owner-freebsd-testing@FreeBSD.ORG Thu Jan 23 22:29:18 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0E1543AA; Thu, 23 Jan 2014 22:29:18 +0000 (UTC) Received: from tx2outboundpool.messaging.microsoft.com (tx2ehsobe002.messaging.microsoft.com [65.55.88.12]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B9C761353; Thu, 23 Jan 2014 22:29:17 +0000 (UTC) Received: from mail174-tx2-R.bigfish.com (10.9.14.226) by TX2EHSOBE006.bigfish.com (10.9.40.26) with Microsoft SMTP Server id 14.1.225.22; Thu, 23 Jan 2014 21:43:47 +0000 Received: from mail174-tx2 (localhost [127.0.0.1]) by mail174-tx2-R.bigfish.com (Postfix) with ESMTP id 83C931001EA; Thu, 23 Jan 2014 21:43:47 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.239.16; KIP:(null); UIP:(null); IPV:NLI; H:P-EMF02-SAC.jnpr.net; RD:none; EFVD:NLI X-SpamScore: 3 X-BigFish: VPS3(zzzz1f42h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h2189h1d1ah1d2ah21bch1fc6h1082kz8dhzz31h2a8h839hd25hf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h14ddh1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh1b88h224fh1fb3h1d0ch1d2eh1d3fh1de2h1dfeh1dffh1e23h1fe8h1ff5h2218h2216h226dh22d0h24afh2327h2336h2381h2438h2461h2487h24ach24d7h1155h) Received-SPF: softfail (mail174-tx2: transitioning domain of juniper.net does not designate 66.129.239.16 as permitted sender) client-ip=66.129.239.16; envelope-from=sjg@juniper.net; helo=P-EMF02-SAC.jnpr.net ; SAC.jnpr.net ; Received: from mail174-tx2 (localhost.localdomain [127.0.0.1]) by mail174-tx2 (MessageSwitch) id 1390513424894285_15512; Thu, 23 Jan 2014 21:43:44 +0000 (UTC) Received: from TX2EHSMHS019.bigfish.com (unknown [10.9.14.227]) by mail174-tx2.bigfish.com (Postfix) with ESMTP id D47903C0049; Thu, 23 Jan 2014 21:43:44 +0000 (UTC) Received: from P-EMF02-SAC.jnpr.net (66.129.239.16) by TX2EHSMHS019.bigfish.com (10.9.99.119) with Microsoft SMTP Server (TLS) id 14.16.227.3; Thu, 23 Jan 2014 21:43:39 +0000 Received: from magenta.juniper.net (172.17.27.123) by P-EMF02-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.146.0; Thu, 23 Jan 2014 13:43:38 -0800 Received: from chaos.jnpr.net (chaos.jnpr.net [172.24.29.229]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id s0NLhaL67857; Thu, 23 Jan 2014 13:43:36 -0800 (PST) (envelope-from sjg@juniper.net) Received: from chaos.jnpr.net (localhost [127.0.0.1]) by chaos.jnpr.net (Postfix) with ESMTP id DD4255807E; Thu, 23 Jan 2014 13:43:35 -0800 (PST) To: Garrett Cooper Subject: Re: Makefile.inc1.patch In-Reply-To: <4DB8E40F-6D7B-41A9-A0FA-B2E241E9A180@gmail.com> References: <4A3E3984-73D3-4441-97A7-D58679EFF978@gmail.com> <9775878D-91AB-4BE4-ADFA-32D8DB582AA6@gmail.com> <4DB8E40F-6D7B-41A9-A0FA-B2E241E9A180@gmail.com> Comments: In-reply-to: Garrett Cooper message dated "Thu, 23 Jan 2014 13:23:57 -0800." From: "Simon J. Gerraty" X-Mailer: MH-E 7.82+cvs; nmh 1.3; GNU Emacs 22.3.1 Date: Thu, 23 Jan 2014 13:43:35 -0800 Message-ID: <20140123214335.DD4255807E@chaos.jnpr.net> MIME-Version: 1.0 Content-Type: text/plain X-OriginatorOrg: juniper.net X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: "freebsd-testing@freebsd.org" , Brooks Davis , sjg@juniper.net X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 22:29:18 -0000 On Thu, 23 Jan 2014 13:23:57 -0800, Garrett Cooper writes: > NO_TESTS forces WITHOUT_TESTS to be set. So, if I set NO_TESTS = >in the various build steps it will force ATF to not be built. For that = >reason (and that reason alone) I reintroduced WITH_ATF just for = >Makefile.inc1 (but you could replace it with something else like = >WITH_ATF_LIBS, etc, if the naming is too confusing). Is there a need to have a knob at all? To build atf libs I mean.