From owner-cvs-all Fri Feb 14 18:25:47 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 321AB37B401; Fri, 14 Feb 2003 18:25:45 -0800 (PST) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id D9DAD43FBF; Fri, 14 Feb 2003 18:25:43 -0800 (PST) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.7/8.12.7) with ESMTP id h1F2PgEJ062698; Sat, 15 Feb 2003 05:25:42 +0300 (MSK) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.7/8.12.6/Submit) id h1F2Pgbx062697; Sat, 15 Feb 2003 05:25:42 +0300 (MSK) (envelope-from ache) Date: Sat, 15 Feb 2003 05:25:42 +0300 From: "Andrey A. Chernov" To: Nate Lawson Cc: Juli Mallett , Kirk McKusick , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/newfs mkfs.c src/sys/ufs/ffs ffs_alloc.c ffs_vfsops.c Message-ID: <20030215022542.GA62285@nagual.pp.ru> References: <20030214221503.GA59673@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Feb 14, 2003 at 16:31:10 -0800, Nate Lawson wrote: > On Sat, 15 Feb 2003, Andrey A. Chernov wrote: > > On Fri, Feb 14, 2003 at 15:33:28 -0600, Juli Mallett wrote: > > > Are the sequences for it also repeatable in the newfs case for e.g. the > > > regression tests, where it is used unseeded? > > > > Obvious answer - no. > > > > BTW, this fix really fixes nothing for FreeBSD case because we already use > > srandomdev() (for non-regression case). > > Speaking totally informally, arc4 is more secure for this purpose than an > LFSR despite seeding the latter via srandomdev(). It isn't big news, arc4random() internal state size is 256 bytes while default random() state size is 124 bytes, but I don't think that anybody can feel that difference inside short range needed for mkfs. The complaint is about broken regression test case, not about srandom()->arc4random() transition taken alone. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message