From owner-freebsd-bugs@freebsd.org Wed Jun 21 15:05:19 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 51461D9191F for ; Wed, 21 Jun 2017 15:05:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 404CE701EC for ; Wed, 21 Jun 2017 15:05:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5LF5Jnx073959 for ; Wed, 21 Jun 2017 15:05:19 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 220186] bhyveload zfs boot broken after zfs boot change Date: Wed, 21 Jun 2017 15:05:19 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: avg@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 15:05:19 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220186 Bug ID: 220186 Summary: bhyveload zfs boot broken after zfs boot change Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: avg@FreeBSD.org There was a recent change to the ZFS boot code that makes check all vdev la= bels for the vdev configuration data. ZFS boot code now requires information ab= out the disk sizes and, as a side effect, it now rejects disks with a too small size. That change exposed a problem in bhyveload. Specifically, it uses fstat(2)= to check a size of a disk. But that seems to work reliably only if the disk i= s a file. If the disk is character device, then st_size is zero and the ZFS bo= ot code rejects such a "zero-sized" disk. It seems that bhyveload, cb_diskioctl() to be precise, needs to check the t= ype of the disk and issue a real DIOCGMEDIASIZE ioctl if it's a character devic= e. The emulation of illumos fstat64() in sys/cddl/compat/opensolaris/sys/stat.h seems to be the code that can be easily reused. --=20 You are receiving this mail because: You are the assignee for the bug.=