Date: Wed, 13 Mar 2013 09:20:00 GMT From: Olivier Smedts <olivier@gid0.org> To: freebsd-rc@FreeBSD.org Subject: Re: conf/174595: /etc/rc.d/sysctl : unknown oid ' XXX' [regression] Message-ID: <201303130920.r2D9K0xI078987@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR conf/174595; it has been noted by GNATS.
From: Olivier Smedts <olivier@gid0.org>
To: bug-followup@FreeBSD.org, olivier@gid0.org
Cc: delphij@freebsd.org
Subject: Re: conf/174595: /etc/rc.d/sysctl : unknown oid 'XXX' [regression]
Date: Wed, 13 Mar 2013 10:11:08 +0100
--047d7b3438ae5a592b04d7cac93f
Content-Type: text/plain; charset=ISO-8859-1
Hi,
Isn't the logic inverted between the start/reload case and the lastload case ?
The attached patch seems logical :
- tell sysctl to ignore unknown OIDs during the "start" case (corrects
the regression)
rationale : some klds still aren't loaded at start, my example with
linux_enable="YES" in rc.conf and compat.linux.osrelease=2.6.32 in
sysctl.conf is a common use case, and it's not meaningful / it's
confusing to show a startup error about a sysctl which couldn't be set
while it actually has been set in lastload stage
- tell sysctl to not ignore unknown OIDs during the "lastload" case
(preserve added value of r244198)
rationale : if an OID is really unknown and couldn't be set neither in
the start nor in the lastload cases, it's useful to be told about the
fatal error
- behave in the "reload" case like in the "lastload" stage
rationale : reloads usually happen after system startup so they're
really a "lastlastload", and it's useful to spit out errors about
unknown OIDs to the operator who asked for a reload
Hoping the attachment won't be stripped,
Olivier
--
Olivier Smedts _
ASCII ribbon campaign ( )
e-mail: olivier@gid0.org - against HTML email & vCards X
www: http://www.gid0.org - against proprietary attachments / \
"Il y a seulement 10 sortes de gens dans le monde :
ceux qui comprennent le binaire,
et ceux qui ne le comprennent pas."
--047d7b3438ae5a592b04d7cac93f
Content-Type: text/plain; charset=US-ASCII; name="patch.txt"
Content-Disposition: attachment; filename="patch.txt"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_he890foi0
LS0tIC91c3Ivc3JjL2V0Yy9yYy5kL3N5c2N0bAkyMDEyLTEyLTE4IDE1OjA3OjEwLjgzMjk2NzU0
MyArMDEwMAorKysgL2V0Yy9yYy5kL3N5c2N0bAkyMDEzLTAzLTEzIDA5OjQ5OjQwLjYzMDk4MTc0
NCArMDEwMApAQCAtMTEsNyArMTEsNyBAQAogY29tbWFuZD0iL3NiaW4vc3lzY3RsIgogc3RvcF9j
bWQ9IjoiCiBzdGFydF9jbWQ9InN5c2N0bF9zdGFydCIKLXJlbG9hZF9jbWQ9InN5c2N0bF9zdGFy
dCIKK3JlbG9hZF9jbWQ9InN5c2N0bF9zdGFydCBsYXN0IgogbGFzdGxvYWRfY21kPSJzeXNjdGxf
c3RhcnQgbGFzdCIKIGV4dHJhX2NvbW1hbmRzPSJyZWxvYWQgbGFzdGxvYWQiCiAKQEAgLTE5LDEw
ICsxOSwxMCBAQAogewogCWNhc2UgJDEgaW4KIAlsYXN0KQotCQljb21tYW5kX2FyZ3M9Ii1pIC1m
IgorCQljb21tYW5kX2FyZ3M9Ii1mIgogCTs7CiAJKikKLQkJY29tbWFuZF9hcmdzPSItZiIKKwkJ
Y29tbWFuZF9hcmdzPSItaSAtZiIKIAk7OwogCWVzYWMKIAo=
--047d7b3438ae5a592b04d7cac93f--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303130920.r2D9K0xI078987>