From nobody Sun Sep 29 02:45:44 2024 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XGT8x1d3Pz5YBpb for ; Sun, 29 Sep 2024 02:45:53 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XGT8x0ydRz4SFd; Sun, 29 Sep 2024 02:45:53 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727577953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1LQGew8yBr1W9Z43rQE1JRufdJNZ1E1wKgKUfiDo8zE=; b=Kuqjf1dF4ErS/4e9zAmrKc+LYP6810Two6BCObDXpa1GWd4HMiwXLad3b8ETQ85i68bFjB sBojCJOvoCHhqmpwdICDfdoEXyMYUvV98WzBWA9mHuQJyAZRzb12k5kXMuiszd2O5f7YXA L4l1TzespKlkvygIPlQrNOfMBlwbKluSvpBf8/dAFDHpfG2d732bqt4pULfhdLpta+sZK6 0QWRHB4pia9B1pXx20FfVSQHNL9X00HXb4oMywsj2lAcgBMyRPitufN5FJXNzet1J/Cs3/ FC7fQe8dQ34Gt2GxS8Z07FAD1r9Q6/LWVW2TlKseqcN4ns1t9Vk68xFffs1GcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727577953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1LQGew8yBr1W9Z43rQE1JRufdJNZ1E1wKgKUfiDo8zE=; b=OsAwXMNo1V8+UgQxVng4F1TozUjCiCrVKDUxRALGQnEKT2nusvtYQRj9vflFQdzE/y7L53 6cJkZg/31RaqO3nYR69CmtL//Fx7i+ZZ7UEF93sljv3sTM5OAaPrw9Bs/hmH79HPb7ft+3 x++Gd7vFlQ7cKg95F+sNom0A9VgRGU8b81pYJeZXutuU3/PYqG0qL8WXOlH1a7kZXZw23W d5eRisEJ7/6ZwCEaXkqbP9eqEBgQZwN9Qk5BkPmBJaWBhLSN/56NQw+0fxZGa4gyWi8pQk WdyfoCqPad9IhE/TefO5lOVlaLkBQi9aaXZ0vf40txFplesTL+5KPOwfb6kQyg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727577953; a=rsa-sha256; cv=none; b=h/qs8+h7v4Nlv1Mr+3vBQFAn4OhgA/vwOWn0XuE3elVq+g5yI/Qm/zTIHqV/Nn0sJ1er07 G6yS1RqTlPDJIS+n0qUxe622M2EINR8E6lKlIPgNplt1GQmZ1eRKGtkqOTqqyvmxLWkTYz Q/F4XoFEMqncjlSkMwaIjpe/ZI1o0A4bKvrsu6RNiFUk10LviQ9lkyEyAkDvaBY7AE5RIU 8ZzjrRVZ+T5NxnbDihIRtgPC+lWaT/OaFgCagbjrADxogT5+8dfACFbvqSpKebYy+4Aou1 Ts9KAUXSRYW8VHHGGeuxC10FuB1JpR1IaaoscBrYamAi/ujPVgq1zPvh69JoIQ== Received: from smtpclient.apple (ns1.oxydns.net [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XGT8v2Rc5zbQy; Sun, 29 Sep 2024 02:45:51 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Content-Type: text/plain; charset=us-ascii List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.10\)) Subject: Re: Is INET6 a required option these days? (kernel build failure) From: Zhenlei Huang In-Reply-To: <20240927120714.35169c6c@ernst.home> Date: Sun, 29 Sep 2024 10:45:44 +0800 Cc: Ian FREISLICH , FreeBSD Current , Kristof Provost Content-Transfer-Encoding: quoted-printable Message-Id: <4E5CBF78-A9AC-4D1C-9D81-CB379C408468@FreeBSD.org> References: <229d4fea-2eed-4710-99f8-f4f91ed539c0@gmail.com> <20240927120714.35169c6c@ernst.home> To: Gary Jennejohn X-Mailer: Apple Mail (2.3696.120.41.1.10) > On Sep 27, 2024, at 6:07 PM, Gary Jennejohn wrote: >=20 > On Thu, 26 Sep 2024 14:58:40 -0400 > Ian FREISLICH wrote: >=20 >> Lately there have been a couple of commits that fail to build because = v6 being compiled in despite INET6 being undefined. I think the latest = is 905db4aa88775865097714c170f4503da385747c. >>=20 >> /usr/src/sys/netpfil/pf/pf.c:8762:38: error: no member named 'icmp6' = in 'union pf_headers'; did you mean 'icmp'? >> 8762 | if (!pf_pull_hdr(m, *off, &pd->hdr.icmp6, = icmp_hlen, >>=20 >> Ian >>=20 >=20 > This happens now and then because most committers have INET6 enabled = and > they forget that INET6 is an option and not mandatory. Kristof is landing lots of commits from upstream ( OpenBSD ), so we need = be patient with him ... >=20 > I don't have INET6 enabled and have reported a number of problems in = the > source as a result of that. >=20 > In general it's pretty simple to fix these problems by merely adding > #ifdef INET6 ... #endif to the code. >=20 > -- > Gary Jennejohn >=20 Best regards, Zhenlei