From owner-svn-src-all@FreeBSD.ORG Sun Jun 6 00:54:10 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3C22D1065673; Sun, 6 Jun 2010 00:54:10 +0000 (UTC) (envelope-from rrs@lakerest.net) Received: from lakerest.net (unknown [IPv6:2001:240:585:2:213:d4ff:fef3:2d8d]) by mx1.freebsd.org (Postfix) with ESMTP id BC3F78FC1D; Sun, 6 Jun 2010 00:54:09 +0000 (UTC) Received: from [192.168.2.108] (pool-96-238-218-232.snfcca.dsl-w.verizon.net [96.238.218.232]) (authenticated bits=0) by lakerest.net (8.14.3/8.14.3) with ESMTP id o560s1jY057412 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sat, 5 Jun 2010 20:54:07 -0400 (EDT) (envelope-from rrs@lakerest.net) DKIM-Signature: a=rsa-sha1; c=simple/simple; d=lakerest.net; s=mail; t=1275785648; h=Cc:Message-Id:From:To:In-Reply-To:Content-Type: Content-Transfer-Encoding:Mime-Version:Subject:Date:References: X-Mailer; b=a2OdwFsoIRHi5t1SMR1bTadBj8Ob3QjAvskCHYEKF90Ue9kDC3jwpNW sH95fvDMWKSmnpjx18ncs5zZDLzoSAg== Message-Id: <3A129572-D7A0-4211-AB71-21C808981C37@lakerest.net> From: Randall Stewart To: Luigi Rizzo In-Reply-To: <20100606004429.GC56080@onelab2.iet.unipi.it> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Date: Sat, 5 Jun 2010 17:53:55 -0700 References: <201006052139.o55LdrBK045695@svn.freebsd.org> <20100606004429.GC56080@onelab2.iet.unipi.it> X-Mailer: Apple Mail (2.936) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r208857 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2010 00:54:10 -0000 Luigi: We on the SCTP team ;-) have always worked under the constraint of "scrubbing out" with un-ifdef loads of stuff for - Windows - MacOS-X - User-Space Implementation - Panda (translated IOS-XR) Now there is a HUGE amount of cruft that has some ugly ifdef's in it which I was told way back was a no-no.... (I was also told unifdef is your friend ;-D) Anyway.. I would be more than glad to bring back the "full" code if folks would all agree.. it actually makes it a lot easier when you are debugging to have the precise line number instead of working between two worlds ;-) But of course we would have to get agreement from quite a few folks... but I am game ;-) R On Jun 5, 2010, at 5:44 PM, Luigi Rizzo wrote: > On Sat, Jun 05, 2010 at 09:39:53PM +0000, Randall Stewart wrote: >> Author: rrs >> Date: Sat Jun 5 21:39:52 2010 >> New Revision: 208857 >> URL: http://svn.freebsd.org/changeset/base/208857 >> >> Log: >> Purge out a Windows def that somehow slipped >> past the scrubber. > > i wonder if it makes sense to scrub away the code for other OS. > While I understand the rationale, seeing the whole code might have > several advantages: > - understand the constraints that other OS impose; > - learn what APIs are available in other OS; > - teach people how to write portable code; > > cheers > luigi > ------------------------------ Randall Stewart 803-317-4952 (cell)