From owner-svn-src-all@freebsd.org Fri Apr 14 21:14:19 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A87B1D3E782; Fri, 14 Apr 2017 21:14:19 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6A6A09D6; Fri, 14 Apr 2017 21:14:19 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x244.google.com with SMTP id g2so17875861pge.2; Fri, 14 Apr 2017 14:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=h4i/VrxLXNXu4AdNnGtVuBN267xh0HMiY/nNoJoer5U=; b=seBb1XUaqSTe7YObmx3n6JYMmYuJcHXFgKjumSykPtqS/htfK4ZdYyhgIU/7VmE0+/ flr6CWqsziCnzOB4tr7k0LBQmO1I9UnvXf2xRWWGsZjc7Qyg8mbadWbJpWNT/LXreLAt gxPRIhsGpST+3UekI9Kr8T3jh+nNSEdKW0lyqL/ZU9v95cwliDp8sv/VoyLlqn/xDUy0 GIknAoJvrLlyJtuXIZE4Xyui6/ytImx5fY0B3TdKtTMcErR5MDDlbCcxmjZcUagEKK/z Nj9chgiedMvF2johp2SayXtaNymq/P0/gTaRxcDLXFwXMMooJn7T3jthHqc65ie8w1FV 9t5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=h4i/VrxLXNXu4AdNnGtVuBN267xh0HMiY/nNoJoer5U=; b=UoMmwA3pTXIsvVAeXuYjsZdN+dsGWi5Z5xxaIZmTq3ELR3s5oKxOrmqDDbdGshHT4E 2wmEXjW6IVJFjk2e6hLOAXhh7GRhPi6lPNdjKheIIcQH+12W2K2nOkF3cChs0ULbQIiu NcmjCJcBij452jvjiB9VA6dqul4VBciMJ3rQ9b0JejbBWF/aTzFvNYCcV21y3dB/a1f4 jPeMJCo5d8helTpm4taAT721qfGSQSMXgvUxXOryFpAX5pRaeCebUiNK1f4YMApEGT11 9sXf0adrtJrUQaR9OcwVEkw4/HZ2wTYe5+DBM/c9rJ0CA7yzyMM4twoxAo9JE5qug5Cl 1mlA== X-Gm-Message-State: AN3rC/7Of6Ym0y44pbuNzRc9MYF7RqxSakFbKJqqSSGgw4bQ+Vakgz7z +qulT3NJFGJQ5wGLg2Q= X-Received: by 10.84.232.68 with SMTP id f4mr11137225pln.90.1492204458970; Fri, 14 Apr 2017 14:14:18 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id p189sm4814546pfb.128.2017.04.14.14.14.17 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Apr 2017 14:14:18 -0700 (PDT) Subject: Re: svn commit: r316874 - head/sys/kern Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_33D0C2FF-AD51-4BEE-9D9E-6749C1E773C8"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Fri, 14 Apr 2017 14:14:16 -0700 Cc: Peter Wemm , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Hiren Panchasara , Hiroki Sato Message-Id: References: <201704141723.v3EHNS3B043902@repo.freebsd.org> <12133324.zHp9vo75vZ@overcee.wemm.org> <6942092.OsECkgAp13@overcee.wemm.org> <513B1846-02E3-49E0-BAA2-CA923EDC5DFF@gmail.com> To: Maxim Sobolev X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 21:14:19 -0000 --Apple-Mail=_33D0C2FF-AD51-4BEE-9D9E-6749C1E773C8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Apr 14, 2017, at 14:10, Maxim Sobolev = wrote: >=20 > Peter, Ngie, >=20 > Looks like out of that refactoring came a logical bug that is present = in the head, which causes syslod to first to shutdown the socket for = reading and then try to select/recv on it (which is somewhat stupid). = And that issue has been masked by shutdown() on datagram socket becoming = effectively a NOP in 11 & head 20 months ago. It only affects head = though, 11-stable still has the old code which does not include that = half-closed socket into the select list. Attached patch is expected to = fix head, Peter, it would be nice if you can give it a try (restoring = latest changes into uipc_sockets.c) and let me know if it helps. >=20 > Thanks! CCing hrs@ for input as he did the refactoring. Thanks! -Ngie PS LGTM with the change. Will wait for feedback from wemm@. --Apple-Mail=_33D0C2FF-AD51-4BEE-9D9E-6749C1E773C8 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY8TupAAoJEPWDqSZpMIYVO/0QAJT8tq4nDLxs65X7lQ2HjOlk v+ba03skz4hkhPU2k3N1sz67CuwFvsqFzlyu1wARBEje5yD1urBy7w6pKNQZbiYi jYdT78AE4q40XZU6XBD7Ne94BSczTe4uI8lfU3VMpv+Fnb1bL54HJ1MFUpTY4IZs KO1/CMv7XOqwuNiZDE2WFFEfTJQIB+JB/tgdQTiW3Aac7XNHiXS7i7hHC4WFp7Vi lsMZ/VGI0Umx6gvOmoimpjAK1fL2QbDh/JHDnklhm3evdIVSiS7cv9cOf+DZMsEH p8iJMHO8x7H4JVvAbJMBLZpLFDCfm47HMkDJZxaZAGhIWN43acefYgDaFnxk6oXt UJL4FoBF8XyTaHevv8Y/3KuxsBRHio36GpSpQ7/EbTw9TielxqZkUlXLAuQThtUt CsAXktFGZa3DAuOQ23/VXx0tTazNwfNuZalnIzaNfAIjCDv5K1Y0xXlz8yJqhmOe QTUOCt5Jz3M1XHhX9fGmx36utuMbavLPvhVEsueQ0JEDGhKXSBlxNIN6XB85YU29 c25O1PkvbcTlBppCMCshAONDcuSBqdjpUGbzPQmv5PXFO+IhNetQHu9PnayLbDNY JCKXIPATL1ZS28xZGASHORSe1oFze30OG5y18O2FbpUOoyDR2m9oOPjDlBZKVRcz qpJ2cJK2xWX7AD0tv3LW =aXDt -----END PGP SIGNATURE----- --Apple-Mail=_33D0C2FF-AD51-4BEE-9D9E-6749C1E773C8--