From owner-freebsd-ports@FreeBSD.ORG Tue Feb 8 18:30:03 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 738D1106564A for ; Tue, 8 Feb 2011 18:30:03 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3336D8FC1B for ; Tue, 8 Feb 2011 18:30:02 +0000 (UTC) Received: by vxa40 with SMTP id 40so2715617vxa.13 for ; Tue, 08 Feb 2011 10:30:02 -0800 (PST) Received: by 10.220.178.10 with SMTP id bk10mr967390vcb.215.1297189801417; Tue, 08 Feb 2011 10:30:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.184.12 with HTTP; Tue, 8 Feb 2011 10:29:39 -0800 (PST) In-Reply-To: References: From: Sunpoet Hsieh Date: Wed, 9 Feb 2011 02:29:39 +0800 Message-ID: To: arrowdodger <6yearold@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-ports@freebsd.org Subject: Re: Request for new port review: TortoiseHG. X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2011 18:30:03 -0000 Hi, First of all, I suggest to set PORTNAME=3Dtortoisehg If you do want to add -hgtk suffix, you may set PKGNAMESUFFIX=3D-hgtk inste= ad. It makes portlint happier. It also simplifies Makefile since DISTNAME is already the default value. On Tue, Feb 8, 2011 at 7:40 PM, arrowdodger <6yearold@gmail.com> wrote: > Hello. I've made a port for TortoiseHG (in fact, for its hgtk script). It= is > my first attempt in port creation, so i want someone to review it. > > The current problems are following: > 1. The user can choose to not install nautilus extension and translation > files (if defined(WITHOUT_NLS)). To prevent setup.py from installing thos= e > stuff, i've made two patches, that resides in ${FILESDIR}. They are > generated from 'diff -u' and the problem is that they cannot be applied > together. If i generate patches with simply 'diff', then everythink works= , > except that i should apply them manually (${PATCH} ${PYSETUP} < > ${FILESDIR}/no-locale.patch). > And what i've been told is that i should use EXTRA_PATCHES, insteand of > invoking patch. > In your case, it can be done without extra patch files. .if !defined(WITH_NAUTILUS) @${REINPLACE_CMD} -e '153,154 D' ${WRKSRC}/${PYSETUP} .endif .if !defined(WITH_NLS) @${REINPLACE_CMD} -e '150,152 D' ${WRKSRC}/${PYSETUP} .endif Here, I suggest a shorter option name "NAUTILUS" instead of "NAUTILUS_EXTENSION". Also, for PLIST_SUB, I think "NLS" is OK for most ports. .if !defined(WITH_NLS) PLIST_SUB+=3D NLS=3D"@comment " .else PLIST_SUB+=3D NLS=3D"" .endif > 2. The port also installs *.egg-info file and i'm not sure how to include= it > in the plist. You should set PYDISTUTILS_EGGINFO=3D. bsd.python.mk will add them to PLIST automatically. PYDISTUTILS_EGGINFO defaults to tortoisehg-1.1.9.1-py2.6.egg-info. (when PORTNAME=3Dtortoisehg) > 3. The port also depends on py-gobject port, but there is no such value i= n > USE_GNOME. I've already mentioned that on freebsd-gnome@ and they said, t= hat > it will be fixed after 8.2-RELEASE. > > You can obtain port from attachement or here: > http://intara.org.ru/tortoisehg.tar.gz > > Thanks in advance. Hope that helps. Regards, --=20 =C2=A0 Sunpoet Po-Chuan Hsieh =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B = 8CC0 DC44 247E CC57 E36B =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 http://people.FreeBSD.org/~sunpoet/pgpkeys.txt