From owner-freebsd-hackers@freebsd.org Thu Nov 19 10:38:54 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6DF04A33A16 for ; Thu, 19 Nov 2015 10:38:54 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 06E5A1014 for ; Thu, 19 Nov 2015 10:38:53 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (ezra.dcm1.omnilan.net [IPv6:2a00:e10:2800::a135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id tAJAcmC7052848; Thu, 19 Nov 2015 11:38:48 +0100 (CET) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (titan.inop.mo1.omnilan.net [IPv6:2001:a60:f0bb:1::3:1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id BE9F99A9; Thu, 19 Nov 2015 11:38:47 +0100 (CET) Message-ID: <564DA6B7.3060705@omnilan.de> Date: Thu, 19 Nov 2015 11:38:47 +0100 From: Harry Schmalzbauer Organization: OmniLAN User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; de-DE; rv:1.9.2.8) Gecko/20100906 Lightning/1.0b2 Thunderbird/3.1.2 MIME-Version: 1.0 To: Doug Ambrisko CC: freebsd-hackers@freebsd.org Subject: Re: Fix MNAMELEN or reimplement struct statfs References: <20140415233133.GA14686@ambrisko.com> <5452600C.5030003@omnilan.de> <20141101154004.GA40398@ambrisko.com> <559FD426.3000108@omnilan.de> <20150710154654.GA71708@ambrisko.com> In-Reply-To: <20150710154654.GA71708@ambrisko.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]); Thu, 19 Nov 2015 11:38:48 +0100 (CET) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: ; Sender-helo: mh0.gentlemail.de; ) X-Mailman-Approved-At: Thu, 19 Nov 2015 12:30:36 +0000 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2015 10:38:54 -0000 Bezüglich Doug Ambrisko's Nachricht vom 10.07.2015 17:46 (localtime): > On Fri, Jul 10, 2015 at 04:18:14PM +0200, Harald Schmalzbauer wrote: > | > | > | Hello, > | > | > | > | first sorry for the missing thread references in the header, I'm not > | > | subscribed to hackers@. > | > | > | > | bdrewery@ pointed me to this discussion in response to my question to > | > | stable@ > | > | (http://lists.freebsd.org/pipermail/freebsd-fs/2014-August/019949.html) > | > | > | > | Last promising post I found: > | > | > | > | > |/ > I have a new patch at: > | > | > /|/ > http://people.freebsd.org/~ambrisko/mount_bigger_2.patch > | > | > /|/ > that I tested against head. This should be pretty close to commiting > | > | > /|/ > unless people find some issues with it. > | > | > /|/ > | > | > /|/ In sys/kern/vfs_mount.c: > | > | > /|/ + mp->mnt_path = malloc(strlen(fspath), M_MOUNT, M_WAITOK); > | > | > /|/ + strlcpy((char *)mp->mnt_path, fspath, strlen(fspath)); > | > | > /|/ > | > | > /|/ This always strips the last byte off the fspath. > | > | > /|/ > | > | > /|/ I like that this only touches the kernel, so it does not break anything > | > | > /|/ regarding mount/umount of filesystems with short paths, including > | > | > /|/ (NFS) filesystems that do not respond. > | > | > /|/ > | > | > /|/ The patch does not enlarge f_mntfromname which may be a problem for > | > | > /|/ nullfs. It is certainly a step forwards for poudriere but [ENAMETOOLONG] > | > | > /|/ errors could still occur in more extreme situations. > | > | > / > | > | > Good point on nullfs. I'll look at fixing that. To do that I'm > | > | > changing mnt_path to mnt_topath so then I can have a mnt_frompath. > | > | > I'll add nullfs to my test cases. I'll need to run through the uses > | > | > of f_mntfromname. It was pretty easy with f_mntonname since it was > | > | > only allocated in one place just used a bunch of other place. I assume > | > | > that mount root would be short. > | > | > | > | Thanks a lot so far for working hard on that problem! > | > | Is there anything newer than "mount_bigger_2.patch", which considers > | > | potential nullfs problems? > | > | I'm heavily using nullfs (without poudriere), but I'd give it a try on > | > | my rather lightly loaded local 10.1 storage box ??? almost all snapshots > | > | are useless, can't access them in case of the case; which happens > | > | frequently :-( > | > | Would I have to expect any nullfs regressions with the april > | > | (mount_bigger_2) patch?? > | > | Bez?glich Doug Ambrisko's Nachricht vom 01.11.2014 16:40 (localtime): > | > I should be able to resume working on this since things are starting to > | > slow down. It shouldn't be much more work to get it finished off to > | > put up for review. > | > | Hello Doug, > | > | I've been using your mount_bigger_2.path for some months without > | problems, but haven't done any kind of stress test. > | It just saves my soul in case I have to recover files from > | (zfs-)snapshots from time to time :-) Hello Doug, unfortunately, mount_bigger doesn't cover the length restriction for make_dev_p(), which leads to inaccessable zvols (g_dev_taste: make_dev_p() failed (gp->name=zvol/babasP0.1xSATA7k2-0/liveBACKSTOR/zfsREPL/esm-vega/P1/iscsi.redtsdatahdd500@epochp2, error=63)) … > ZFS. Kirk asked me not to continue with this since it would make > the 64 bit inode work harder and that they were going to bump up > the max of the mount point. He also mentioned that it couldn't be > merged back since it changes the kernel API. So I'm not sure > where that leaves us for now except that this works for us. I use … Do you have any news regarding this issue? I haven't followed the whole development in that area for quiet some time, but just tried 10/stable (r290995) and found this beeing still unresolved. Thanks, -Harry