From owner-freebsd-ports@FreeBSD.ORG Thu Jan 3 12:14:10 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 7D7B2819 for ; Thu, 3 Jan 2013 12:14:10 +0000 (UTC) (envelope-from freebsd-listen@fabiankeil.de) Received: from smtprelay02.ispgateway.de (smtprelay02.ispgateway.de [80.67.18.44]) by mx1.freebsd.org (Postfix) with ESMTP id EB82E2E9 for ; Thu, 3 Jan 2013 12:14:09 +0000 (UTC) Received: from [78.35.166.68] (helo=fabiankeil.de) by smtprelay02.ispgateway.de with esmtpsa (SSLv3:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1TqjgP-0004VS-UX; Thu, 03 Jan 2013 13:14:02 +0100 Date: Thu, 3 Jan 2013 13:12:43 +0100 From: Fabian Keil To: freebsd-ports@freebsd.org Subject: Re: What is policy about auto-editing config files on port install / deinstall? Message-ID: <20130103131243.043c47cf@fabiankeil.de> In-Reply-To: References: <50E49A73.2070008@quip.cz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/9cmteYDjLkejChhtzcAd9JC"; protocol="application/pgp-signature" X-Df-Sender: Nzc1MDY3 Cc: Scot Hetzel , Miroslav Lachman <000.fbsd@quip.cz> X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2013 12:14:10 -0000 --Sig_/9cmteYDjLkejChhtzcAd9JC Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Scot Hetzel wrote: > On Wed, Jan 2, 2013 at 2:37 PM, Miroslav Lachman <000.fbsd@quip.cz> wrote: > > Is somewhere written policy or portmgr recommendation about ports behav= ior > > on install / deinstall? My impression is that every maintainer has her own undocumented policy although the approaches taken could be grouped into a few categories. > > I am talking about some ports doing "nasty" things. > > > > Some ports are stopping services on deinstall, some not. >=20 > I prefer that when a port is uninstalled, that the service is stopped. As long as it is optional and doesn't happen automatically I could live with that. At least to me "uninstalling a port" (with pkg or pkg_delete) means removing the files it installed and does not necessary imply "also kill whatever process is related to these files". > If it isn't stopped, it could pose a security risk to the system at a > later time. Stopping a service can pose a security risk as well, so I don't think that's a good argument as it depends on the port. > > Some ports are editing "my config files" on deinstall, so even on upgra= de > > procedure I must check if port did some changes before I can restart ta= rget > > daemon. > > > Most ports don't edit the config files as they install the original > config file to a different name. In my opinion ports shouldn't mess with user-modified files unless they properly parse them and can be expected not to break them. And even then I don't think it should be done automatically without user interaction. I believe that's currently up to the maintainer as well, though. Fabian --Sig_/9cmteYDjLkejChhtzcAd9JC Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDldb4ACgkQBYqIVf93VJ2zogCgs7L1xHC9EeDNgUj5+QUqNUoO lfwAn17V/D7Uh6Yna2Wq7qDIZy3lApfc =gelQ -----END PGP SIGNATURE----- --Sig_/9cmteYDjLkejChhtzcAd9JC--