Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 21 Jul 2012 11:55:57 +0400
From:      Andrej Zverev <az@freebsd.org>
To:        Carlo Strub <cs@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r301236 - in head/security: . p5-GnuPG
Message-ID:  <CAD5bB%2Bj=nNh%2BMSJ97JrNvcSDdFL2Zum_Mv1yCJaqMOYxBUE6Xg@mail.gmail.com>
In-Reply-To: <201207201928.q6KJSsPG029089@svn.freebsd.org>
References:  <201207201928.q6KJSsPG029089@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hello.

1. It's very bad practice to add new port and assign it to perl@. Why
man who submitted PR don't want to be maintainer?
2. man-plist - I think this file is useless and must be removed.
3. We don't need name of submitter in pkg-descr after the WWW line.


On Fri, Jul 20, 2012 at 11:28 PM, Carlo Strub <cs@freebsd.org> wrote:
> Author: cs
> Date: Fri Jul 20 19:28:54 2012
> New Revision: 301236
> URL: http://svn.freebsd.org/changeset/ports/301236
>
> Log:
>   GnuPG - Perl module interface to the GNU Privacy Guard (v1.x.x series)
>
>   WWW:  http://search.cpan.org/dist/GnuPG/
>
>   Marcello Coutinho
>
>   PR:           ports/169957
>   Submitted by: Marcello Coutinho
>
> Added:
>   head/security/p5-GnuPG/
>   head/security/p5-GnuPG/Makefile   (contents, props changed)
>   head/security/p5-GnuPG/distinfo   (contents, props changed)
>   head/security/p5-GnuPG/man-plist   (contents, props changed)
>   head/security/p5-GnuPG/pkg-descr   (contents, props changed)
>   head/security/p5-GnuPG/pkg-plist   (contents, props changed)
> Modified:
>   head/security/Makefile
>
> Modified: head/security/Makefile
> ==============================================================================
> --- head/security/Makefile      Fri Jul 20 18:35:12 2012        (r301235)
> +++ head/security/Makefile      Fri Jul 20 19:28:54 2012        (r301236)
> @@ -540,6 +540,7 @@
>      SUBDIR += p5-Filter-Crypto
>      SUBDIR += p5-GD-SecurityImage
>      SUBDIR += p5-GSSAPI
> +    SUBDIR += p5-GnuPG
>      SUBDIR += p5-GnuPG-Interface
>      SUBDIR += p5-HTML-Email-Obfuscate
>      SUBDIR += p5-IO-Async-SSL
>
> Added: head/security/p5-GnuPG/Makefile
> ==============================================================================
> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> +++ head/security/p5-GnuPG/Makefile     Fri Jul 20 19:28:54 2012        (r301236)
> @@ -0,0 +1,26 @@
> +# New ports collection makefile for:   p5-GnuPG
> +# Date created:                                2012-07-17
> +# Whom:                                        Marcello Coutinho
> +#
> +# $FreeBSD$
> +#
> +
> +PORTNAME=      GnuPG
> +PORTVERSION=   0.19
> +CATEGORIES=    security perl5
> +MASTER_SITES=  CPAN
> +PKGNAMEPREFIX= p5-
> +
> +MAINTAINER=    perl@FreeBSD.org
> +COMMENT=       Perl module for interfacing with GnuPG
> +
> +LICENSE=       GPLv2
> +
> +PERL_CONFIGURE=        yes
> +
> +MAN3=  GnuPG.3 \
> +       GnuPG::Tie.3
> +
> +MAN1=  gpgmailtunl.1
> +
> +.include <bsd.port.mk>
>
> Added: head/security/p5-GnuPG/distinfo
> ==============================================================================
> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> +++ head/security/p5-GnuPG/distinfo     Fri Jul 20 19:28:54 2012        (r301236)
> @@ -0,0 +1,2 @@
> +SHA256 (GnuPG-0.19.tar.gz) = af53f2d3f63297e046676eae14a76296afdd2910e09723b6b113708622b7989b
> +SIZE (GnuPG-0.19.tar.gz) = 32665
>
> Added: head/security/p5-GnuPG/man-plist
> ==============================================================================
> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> +++ head/security/p5-GnuPG/man-plist    Fri Jul 20 19:28:54 2012        (r301236)
> @@ -0,0 +1 @@
> +       gpgmailtunl.1.gz \
>
> Added: head/security/p5-GnuPG/pkg-descr
> ==============================================================================
> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> +++ head/security/p5-GnuPG/pkg-descr    Fri Jul 20 19:28:54 2012        (r301236)
> @@ -0,0 +1,5 @@
> +GnuPG - Perl module interface to the GNU Privacy Guard (v1.x.x series)
> +
> +WWW:  http://search.cpan.org/dist/GnuPG/
> +
> +Marcello Coutinho
>
> Added: head/security/p5-GnuPG/pkg-plist
> ==============================================================================
> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> +++ head/security/p5-GnuPG/pkg-plist    Fri Jul 20 19:28:54 2012        (r301236)
> @@ -0,0 +1,11 @@
> +bin/gpgmailtunl
> +%%SITE_PERL%%/GnuPG.pm
> +%%SITE_PERL%%/GnuPG/Tie.pm
> +%%SITE_PERL%%/GnuPG/Tie/ClearSign.pm
> +%%SITE_PERL%%/GnuPG/Tie/Decrypt.pm
> +%%SITE_PERL%%/GnuPG/Tie/Encrypt.pm
> +%%SITE_PERL%%/GnuPG/Tie/Sign.pm
> +%%SITE_PERL%%/%%PERL_ARCH%%/auto/GnuPG/.packlist
> +@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/GnuPG
> +@dirrm %%SITE_PERL%%/GnuPG/Tie
> +@dirrm %%SITE_PERL%%/GnuPG



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAD5bB%2Bj=nNh%2BMSJ97JrNvcSDdFL2Zum_Mv1yCJaqMOYxBUE6Xg>