From owner-svn-src-all@freebsd.org Sat Dec 23 06:11:21 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B8E0E9B4CB; Sat, 23 Dec 2017 06:11:21 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 05C8D77C3B; Sat, 23 Dec 2017 06:11:20 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id vBN6BKO8074530; Sat, 23 Dec 2017 06:11:20 GMT (envelope-from imp@FreeBSD.org) Received: (from imp@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id vBN6BK7W074529; Sat, 23 Dec 2017 06:11:20 GMT (envelope-from imp@FreeBSD.org) Message-Id: <201712230611.vBN6BK7W074529@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: imp set sender to imp@FreeBSD.org using -f From: Warner Losh Date: Sat, 23 Dec 2017 06:11:20 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r327101 - head/sys/dev/pccard X-SVN-Group: head X-SVN-Commit-Author: imp X-SVN-Commit-Paths: head/sys/dev/pccard X-SVN-Commit-Revision: 327101 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Dec 2017 06:11:21 -0000 Author: imp Date: Sat Dec 23 06:11:19 2017 New Revision: 327101 URL: https://svnweb.freebsd.org/changeset/base/327101 Log: Expand cryptic comment with inforation I've learned in the mean time about CIS3/CIS4, including studies I've done on my large collection of PC Cards bought off e-bay over the years since the original entry as well as conversations I've had at conferences. Modified: head/sys/dev/pccard/pccardvar.h Modified: head/sys/dev/pccard/pccardvar.h ============================================================================== --- head/sys/dev/pccard/pccardvar.h Sat Dec 23 05:32:20 2017 (r327100) +++ head/sys/dev/pccard/pccardvar.h Sat Dec 23 06:11:19 2017 (r327101) @@ -88,10 +88,18 @@ struct pccard_product { }; /** - * Note: There's no cis3 or cis4 reported for NOMATCH / pnpinfo events for pccard - * It's unclear if we actually need that for automatic loading or not. These stirngs - * are informative, according to the standard, but I have a dim memory of using these - * strings to match things, though I can't find the example right now. + * Note: There's no cis3 or cis4 reported for NOMATCH / pnpinfo events for + * pccard It's unclear if we actually need that for automatic loading or + * not. These stirngs are informative, according to the standard. Some Linux + * drivers match on them, for example. However, FreeBSD's hardware probing is a + * little different than Linux so it turns out we don't need them. Some cards + * use CIS3 or CIS4 for a textual representation of the MAC address. In short, + * they aren't needed even though our friends in Linux have them. It is my + * belief that all the entries in Linux don't actually need to be separate there + * either, but it's hard to eliminate them and retest on old, possibly rare, + * hardware so they persist. Despite years of collecting ~300 different PC Cards + * off E-Bay, I've not been able to find any that need CIS3/CIS4 to select which + * device attaches. */ #define PCCARD_PNP_DESCR "D:#;V32:manufacturer;V32:product;Z:cisvendor;Z:cisproduct;" #define PCCARD_PNP_INFO(t) \